feat(funnels): use hogql for legacy insight funnels api #27420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thmsobrmlr
force-pushed
the
legacy-api-use-hogql-funnels
branch
from
88c1fdf to
2f26460
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
anirudhpillai
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to use HogQL queries for computing the legacy insight API endpoints. We use
/queryeverywhere in our codebase, but the endpoints can still be called by customers.Changes
Changes computation of the funnels endpoint to HogQL.
How did you test this code?
CI Run
and calling
http://localhost:8000/api/projects/1/insights/funnel
http://localhost:8000/api/projects/1/insights/funnel?query_method=legacy
with
{ "events": [ {"id": "$pageview", "order": 0}, {"id": "$pageview", "order": 1}, {"id": "$pageview", "order": 2} ], "insight": "FUNNELS", "date_from": "2025-01-01", "date_to": "2025-01-08", "funnel_window_days": 7, "funnel_order_type": "unordered", "breakdown_type": "event", "breakdown": "$browser" }