Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 IOs basic subsystems #119

Closed
wants to merge 4 commits into from
Closed

Conversation

Jacob1010-h
Copy link
Member

No description provided.

@Jacob1010-h Jacob1010-h added the enhancement New feature or request label Feb 3, 2024
@Jacob1010-h Jacob1010-h requested a review from GalexY727 February 3, 2024 06:31
@Jacob1010-h Jacob1010-h self-assigned this Feb 3, 2024
@Jacob1010-h Jacob1010-h linked an issue Feb 3, 2024 that may be closed by this pull request
1 task
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel that these changes are necessary to the robot-- I think that since Neo already works in sim we have no reason to do IO, we can already replay logs by using the submit data function in advantageScoperies

@GalexY727
Copy link
Member

I was thinking that the purpose of #115 would be to make a temporary class as the subsystem is being developed, and then delete the IO once the subsystem is made. This way we don't have stale files that serve no purpose but to add more lines of code to our repository-- this robot is getting pretty complex with the closure of #73 being "soon"™

@GalexY727
Copy link
Member

@RudyG252 @Oliver-Cushman i would like opinions on this oneeee

@GalexY727
Copy link
Member

This guy knows his shapez class

@Jacob1010-h
Copy link
Member Author

I was thinking that the purpose of #115 would be to make a temporary class as the subsystem is being developed, and then delete the IO once the subsystem is made. This way we don't have stale files that serve no purpose but to add more lines of code to our repository-- this robot is getting pretty complex with the closure of #73 being "soon"™

I get that, tbh I completely agree, and as a result these files might be completely unnecessary at this point in the code.

Copy link
Contributor

@Oliver-Cushman Oliver-Cushman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the reasoning behind these changes and the code itself looks good to me. However, I don't know if these changes are entirely necessary as they seem to just add more bulk. I agree with @GalexY727 in that using these interfaces is a good way to set up our subsystems in the future, but they don't seem to be needed now that we are in the later stages of programming the bot.

@Jacob1010-h Jacob1010-h closed this Feb 3, 2024
@Jacob1010-h Jacob1010-h deleted the 115-IOs-basic-subsystems branch February 3, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Making Interfaces for basic subsystems
3 participants