-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
115 IOs basic subsystems #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't feel that these changes are necessary to the robot-- I think that since Neo already works in sim we have no reason to do IO, we can already replay logs by using the submit data function in advantageScoperies
I was thinking that the purpose of #115 would be to make a temporary class as the subsystem is being developed, and then delete the IO once the subsystem is made. This way we don't have stale files that serve no purpose but to add more lines of code to our repository-- this robot is getting pretty complex with the closure of #73 being "soon"™ |
@RudyG252 @Oliver-Cushman i would like opinions on this oneeee |
This guy knows his shapez class |
I get that, tbh I completely agree, and as a result these files might be completely unnecessary at this point in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the reasoning behind these changes and the code itself looks good to me. However, I don't know if these changes are entirely necessary as they seem to just add more bulk. I agree with @GalexY727 in that using these interfaces is a good way to set up our subsystems in the future, but they don't seem to be needed now that we are in the later stages of programming the bot.
No description provided.