Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(contrib): create PULL_REQUEST_TEMPLATE.md #244

Merged
merged 27 commits into from
Jan 21, 2023
Merged
Changes from 15 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c8c92f9
new(contrib): create PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
41ce4f1
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
551b807
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
27bb658
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
9821452
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
8a14dea
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
13c999e
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
3d33e1b
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 17, 2023
c6697e6
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
806014c
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
e13d0d7
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
820994b
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
8c173e2
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
f1f1e52
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
0c4df8a
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
685ea18
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
1a52f46
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
4ed3595
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
19908fc
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
bf50830
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
22dfbaf
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
543a298
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
a6c8d19
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 19, 2023
c18d70a
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 20, 2023
0200517
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 20, 2023
5f68edc
Update .github/PULL_REQUEST_TEMPLATE.md
DerekNonGeneric Jan 20, 2023
197fe24
Apply suggestions from code review
shellscape Jan 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<!--
⚡️ katchow! We ❤️ Pull Requests! If you remove or skip this template, you'll
make the 🐼 sad and the mighty god of GitHub will appear and pile-drive the
close button from a great height while making animal noises.

DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
Before submitting, we would advise you to first read
https://github.com/OpenINF/.github/blob/HEAD/CONTRIBUTING.md

Pull Request Requirements:

- Please include tests to illustrate the problem this PR resolves.
- Please lint your changes by running `npm run lint` before creating a PR.
shellscape marked this conversation as resolved.
Show resolved Hide resolved
- Please update the documentation in `/doc` where necessary.
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
- Please place an x (no spaces - [x]) in all [ ] that apply.
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
-->

# What This PR (Pull Request) Does

This PR contains:

- [ ] bugfix
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
- [ ] feature
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
- [ ] ♻️ refactoring
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
- [ ] 📄 documentation
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
- [ ] other
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved

Are tests included?

DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
<!--
If your PR fixes a bug (🐜/🐛/🐞), the existing tests are 100% sure not to cover
the expected behavior. Update them, or add new ones. 🧪✅
-->

- [ ] yes (_bugfixes and features will not be merged without tests_)
- [ ] no

Breaking Changes?

- [ ] yes (_breaking changes will not be merged unless absolutely necessary_)
- [ ] no

If yes, then include "BREAKING CHANGES:" in the first commit message body,
DerekNonGeneric marked this conversation as resolved.
Show resolved Hide resolved
followed by a description of what is breaking.

List any relevant issue numbers:

## Description

<!--
Please be thorough and clearly explain the problem being solved.

- If this PR adds a feature, look for previous discussion on the feature by
searching the issues first.
- Is this PR related to an issue?
-->