Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(contrib): create PULL_REQUEST_TEMPLATE.md #244

Merged
merged 27 commits into from
Jan 21, 2023
Merged

Conversation

DerekNonGeneric
Copy link
Member

Derived from rollup/plugins w/ permission from @shellscape.

Signed-off-by: Derek Lewis [email protected]

Derived from rollup/plugins w/ permission from @shellscape.

Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric
Copy link
Member Author

Since we cannot configure @semantic-prs Semantic PR app, we are going to remove.

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Jan 17, 2023

This what we previously had:

🔗 https://raw.githubusercontent.com/openinf/openinf.github.io/live/.github/PULL_REQUEST_TEMPLATE.md

Will try blending the two?

@DerekNonGeneric DerekNonGeneric added wip Issues and PRs that are still a work in progress depends-on Issues and PRs that depend on other workstreams being completed first inclusion labels Jan 19, 2023
@DerekNonGeneric
Copy link
Member Author

Depends on #22

DerekNonGeneric and others added 2 commits January 19, 2023 20:31
Co-authored-by: Derek Lewis <[email protected]>
Signed-off-by: Andrew Powell <[email protected]>
@shellscape shellscape marked this pull request as ready for review January 21, 2023 03:17
@shellscape shellscape merged commit 4b5288b into main Jan 21, 2023
@shellscape shellscape deleted the new/add-pr-template branch January 21, 2023 03:24
DerekNonGeneric added a commit that referenced this pull request Jan 21, 2023
Refs: GH-244

Signed-off-by: Derek Lewis <[email protected]>
@DerekNonGeneric DerekNonGeneric removed the wip Issues and PRs that are still a work in progress label Jan 21, 2023
DerekNonGeneric added a commit that referenced this pull request Feb 22, 2023
* new(contrib): create PULL_REQUEST_TEMPLATE.md

Derived from rollup/plugins w/ permission from @shellscape.

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Update .github/PULL_REQUEST_TEMPLATE.md

Signed-off-by: Derek Lewis <[email protected]>

* Apply suggestions from code review

Co-authored-by: Derek Lewis <[email protected]>
Signed-off-by: Andrew Powell <[email protected]>

Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Andrew Powell <[email protected]>
Co-authored-by: Andrew Powell <[email protected]>
DerekNonGeneric added a commit that referenced this pull request Feb 22, 2023
Refs: GH-244

Signed-off-by: Derek Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends-on Issues and PRs that depend on other workstreams being completed first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants