Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nixos-24.11] mono: add mainProgram #369229

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

GaetanLepage
Copy link
Contributor

Things done

cc @thoughtpolice @obadz

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage changed the title mono: add mainProgram [nixos-24.11] mono: add mainProgram Dec 29, 2024
@GaetanLepage GaetanLepage requested a review from vcunat December 29, 2024 20:51
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 29, 2024
@vcunat vcunat mentioned this pull request Dec 29, 2024
13 tasks
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Dec 29, 2024
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds worth backporting even if it didn't fix the channel. I checked that it does fix

nix build -f pkgs/top-level/release.nix release-checks

@vcunat vcunat merged commit dca3934 into NixOS:release-24.11 Dec 29, 2024
31 of 32 checks passed
@GaetanLepage GaetanLepage deleted the mono branch December 29, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants