Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mono: set meta.mainProgram #358022

Merged
merged 2 commits into from
Nov 23, 2024
Merged

mono: set meta.mainProgram #358022

merged 2 commits into from
Nov 23, 2024

Conversation

UlyssesZh
Copy link
Member

Very simple PR for setting mono.meta.mainProgram = "mono";.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 22, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 23, 2024
@Aleksanaa Aleksanaa merged commit 8f0923a into NixOS:master Nov 23, 2024
35 of 36 checks passed
@vcunat vcunat added the backport release-24.11 Backport PR automatically label Dec 29, 2024
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 29, 2024

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-358022-to-release-24.11 origin/release-24.11
cd .worktree/backport-358022-to-release-24.11
git switch --create backport-358022-to-release-24.11
git cherry-pick -x 17a8a6b7e475d78c3eea4f9112759a8649088a08 4d2a2ff20dd9c9ac96694261a87ed44fb11a50ea

@vcunat
Copy link
Member

vcunat commented Dec 29, 2024

Oh, I didn't notice that there are two commits in this PR. Anyway, backport in #369229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants