Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ride: bump nan version to fix build with nodejs_22 #369163

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Dec 29, 2024

Fixes the build of ride
https://hydra.nixos.org/build/282401398/nixlog/2

Will probably report this upstream later.

Generated the patch by running npm update nan

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 29, 2024
@MaxCan-Code
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369163


x86_64-linux

✅ 1 package built:
  • ride

@TomaSajt
Copy link
Contributor Author

Rebased onto master (also to retrigger CI)

@nix-owners nix-owners bot requested a review from markus1189 January 14, 2025 23:22
@pbsds pbsds merged commit d5d0699 into NixOS:master Jan 19, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants