Skip to content

Commit

Permalink
ride: bump nan version to fix build with nodejs_22
Browse files Browse the repository at this point in the history
  • Loading branch information
TomaSajt committed Jan 2, 2025
1 parent fa99ba3 commit bf39105
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pkgs/by-name/ri/ride/package.nix
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ buildNpmPackage rec {
hash = "sha256-xR+HVC1JVrPkgPhIJZxdTVG52+QbanmD1c/uO5l84oc=";
};

npmDepsHash = "sha256-h+48/9h7/cD8woyA0UCLtzKuE9jCrfpDk6IeoDWnYik=";
npmDepsHash = "sha256-C8puCz/w5xkaR4QVXXOdoO8n4gNZrRWMcB9/f1DcuMc=";

patches = [
# Adds support for electron versions >=28
Expand All @@ -40,6 +40,9 @@ buildNpmPackage rec {
(replaceVars ./mk.patch {
inherit version;
})

# would not build with nodejs_22 and above without this
./update-nan.patch
];

postPatch = ''
Expand Down
31 changes: 31 additions & 0 deletions pkgs/by-name/ri/ride/update-nan.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
diff --git a/package-lock.json b/package-lock.json
index a0bd285..5a5ec59 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -8034,9 +8034,10 @@
"dev": true
},
"node_modules/nan": {
- "version": "2.17.0",
- "resolved": "https://registry.npmjs.org/nan/-/nan-2.17.0.tgz",
- "integrity": "sha512-2ZTgtl0nJsO0KQCjEpxcIr5D+Yv90plTitZt9JBfQvVJDS5seMl3FOvsh3+9CoYWXf/1l5OaZzzF6nDm4cagaQ==",
+ "version": "2.22.0",
+ "resolved": "https://registry.npmjs.org/nan/-/nan-2.22.0.tgz",
+ "integrity": "sha512-nbajikzWTMwsW+eSsNm3QwlOs7het9gGJU5dDZzRTQGk03vyBOauxgI4VakDzE0PtsGTmXPsXTbbjVhRwR5mpw==",
+ "license": "MIT",
"optional": true
},
"node_modules/nanomatch": {
@@ -18258,9 +18259,9 @@
"dev": true
},
"nan": {
- "version": "2.17.0",
- "resolved": "https://registry.npmjs.org/nan/-/nan-2.17.0.tgz",
- "integrity": "sha512-2ZTgtl0nJsO0KQCjEpxcIr5D+Yv90plTitZt9JBfQvVJDS5seMl3FOvsh3+9CoYWXf/1l5OaZzzF6nDm4cagaQ==",
+ "version": "2.22.0",
+ "resolved": "https://registry.npmjs.org/nan/-/nan-2.22.0.tgz",
+ "integrity": "sha512-nbajikzWTMwsW+eSsNm3QwlOs7het9gGJU5dDZzRTQGk03vyBOauxgI4VakDzE0PtsGTmXPsXTbbjVhRwR5mpw==",
"optional": true
},
"nanomatch": {

0 comments on commit bf39105

Please sign in to comment.