Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shticker-book-unwritten: fix fhsenv version #359405

Merged

Conversation

Stunkymonkey
Copy link
Contributor

part of #336576

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Pandapip1 Pandapip1 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 26, 2024
@Pandapip1
Copy link
Contributor

Pandapip1 commented Nov 26, 2024

This can be marked as ready for review. Separately: might it make sense to expose the unwrapped version?

@Stunkymonkey Stunkymonkey marked this pull request as ready for review November 26, 2024 22:19
@Stunkymonkey
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 359405


x86_64-linux

✅ 1 package built:
  • shticker-book-unwritten

@Stunkymonkey
Copy link
Contributor Author

@Pandapip1:

might it make sense to expose the unwrapped version?

what do you mean? I am doing this... (i fail to understand your point)

@Pandapip1
Copy link
Contributor

I meant in a separate PR, but moving pkgs/by-name/shticker-book-unwritten/unwrapped.nix to pkgs/by-name/shticker-book-unwritten-unwrapped/package.nix

@Stunkymonkey Stunkymonkey merged commit d957d40 into NixOS:master Nov 26, 2024
19 of 20 checks passed
@Stunkymonkey Stunkymonkey deleted the shticker-book-unwritten-fhsenv-version branch November 26, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants