[Tracking issue] `buildFHSEnv`-based derivations in nixpkgs often omit `version` #336576

Pandapip1 · 2024-08-22T16:56:35Z

Issue description

A lot of buildFHSnv-based derivations in nixpkgs omit version. This is incorrect in almost all cases.

Examples

https://github.com/NixOS/nixpkgs/blob/b9d225182c390ca02b1a0d068a7f12c1c838d538/pkgs/by-name/en/envision/package.nix
https://github.com/NixOS/nixpkgs/blob/b9d225182c390ca02b1a0d068a7f12c1c838d538/pkgs/applications/misc/bottles/default.nix
https://github.com/NixOS/nixpkgs/blob/b9d225182c390ca02b1a0d068a7f12c1c838d538/pkgs/applications/misc/lutris/fhsenv.nix
https://github.com/NixOS/nixpkgs/blob/2d7db58c2fddcf05871e426318941146496e8992/pkgs/applications/graphics/unigine-superposition/default.nix
https://github.com/NixOS/nixpkgs/blob/2d7db58c2fddcf05871e426318941146496e8992/pkgs/applications/graphics/unigine-superposition/default.nix
https://github.com/NixOS/nixpkgs/blob/2d7db58c2fddcf05871e426318941146496e8992/pkgs/applications/misc/sidequest/default.nix

There are many more, this was just a cursory search through the first few pages of git grep buildFHSEnv

The text was updated successfully, but these errors were encountered:

tomodachi94 · 2024-10-16T03:35:05Z

Stunkymonkey · 2024-11-03T22:19:52Z

@Pandapip1 what version do you expect to b given? seems similar to "environments", "patches": #103997 (comment)

is it all 1.0.0 (seems odd for me)? Or the same version as the package (then how would you deal with multiple packages being combined in a single one)?

we first should find a reasonable agreement, before we take actions

Pandapip1 · 2024-11-03T22:59:51Z

is it all 1.0.0 (seems odd for me)? Or the same version as the package (then how would you deal with multiple packages being combined in a single one)?

The same version as the package corresponding to meta.mainProgram or runScript, if it exists (e.g. heroic's FHSEnv should obviously share a version with the heroic package).

Side note: ./pkgs/tools/package-management/appimage-run/default.nix seems like a false positive.

UlyssesZh · 2024-11-23T05:35:07Z

Is there relevant documentation about this? If not, maybe this is more of a documentation problem?

Pandapip1 · 2024-11-23T09:56:37Z

Is there relevant documentation about this? If not, maybe this is more of a documentation problem?

I mean, I presume that the version parameter has to be documented somewhere (although it's telling that I couldn't actually find said documentation in the two minutes I spent searching the nixpkgs manual). The main reason I bring this up is because tools such as https://search.nixos.org/ and https://repology.org/projects/?inrepo=nix_unstable can't show versions if they aren't set.

Stunkymonkey · 2024-11-26T20:29:12Z

with ./pkgs/tools/package-management/appimage-run/default.nix we will run into trouble, because passing the version parameter is not enforced, but just optional.

Pandapip1 · 2024-11-26T22:02:22Z

FWIW your bash script misses a few (e.g. https://github.com/NixOS/nixpkgs/blob/2d7db58c2fddcf05871e426318941146496e8992/pkgs/applications/graphics/unigine-superposition/default.nix). A manual pass might be needed.

Stunkymonkey · 2024-11-28T21:17:32Z

I am going to start a list of what I expect to be skip: (I will add more when i find them)

./pkgs/tools/package-management/appimage-run/default.nix
./pkgs/test/buildFHSEnv/default.nix
./pkgs/games/steam/fhsenv.nix

Stunkymonkey · 2024-12-12T21:31:35Z

@Pandapip1 i think i went through all. the exceptions are documented in #336576 (comment)

from my POV this issue is done.

Pandapip1 · 2024-12-13T22:06:38Z

All PRs appear to be merged!

This is an attempt to package [Olympus](https://everestapi.github.io/), a GUI for installing Everest and managing Celeste mods. This is based on this [draft](NixOS#295258), with the authors permission. It maintains the previous issue of not being able to launch Steam versions of Celeste from the command line but that's not feasible without upstream changes. I only have to note that it has a popup complaining about finishing the installation but that's due to xdg-mime x-scheme-handler/everest not being set. Finally I want to note that it depends on lua51Packages.nfd, which is broken while [this](NixOS#309026) isn't merged so currently has the fix there. Finally, [Lönn](https://github.com/CelestialCartographers/Loenn) works as expected, being the installation managed by the program. Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic executables olympus: fixed zenity argument olympus: bugfix add openssl to fhs olympus: fixed to use the default nfd instead of patched version olympus: changed location of ndf arg olympus: bugfix: add xdg-utils as runtime dependency to fix pop-up olympus: deleted zenity.patch Due to nfd lua package being fixed, this patch is no longer needed olympus: fix use of wrong nfd package olympus: bumped up version to 24.07.06.02 olympus: format files with nixfmt-rfc olympus: chores: comments, fixed lib conventions olympus: make wrappers properly, use standard build process, misc fixes olympus: update version, src; add updateScript olympus: avoid rec; use lib.getExe; remove redundant .out; minor changes olympus: use standard build process for dotnet; remove -nixos suffix in version; use new mono; add dotnet-runtime to fhs env olympus: 24.10.27.02 -> 24.11.23.01; fix version.txt; remove unnecessary dependencies; add miniinstaller and celeste wrapper; other misc change olympus-with-steam-run: init olympus: more flexible celeste wrapper olympus: accept emptry string and path as celeste wrapper; minor fix with lua cpath olympus: minor fix with lua cpath; add xdg-utils to path olympus: use standard lua-subprocess instead of fork olympus: make MiniInstaller be properly wrapped olympus: add option to skip handler olympus: tweaked platforms, tweaked miniinstaller-fhs olympus-with-steam-run: comment for reminder on fixing issues with relative paths olympus: removed extraneous package olympus: add extra wrapper options for mininstaller and loenn olympus: add more explicit comments, bump version olympus: fixed mismatched hash in olympus olympus: changed proprieties of miniinstaller-fhs (NixOS#336576)

This is an attempt to package [Olympus](https://everestapi.github.io/), a GUI for installing Everest and managing Celeste mods. This is based on this [draft](NixOS#295258), with the authors permission. It maintains the previous issue of not being able to launch Steam versions of Celeste from the command line but that's not feasible without upstream changes. I only have to note that it has a popup complaining about finishing the installation but that's due to xdg-mime x-scheme-handler/everest not being set. Finally I want to note that it depends on lua51Packages.nfd, which is broken while [this](NixOS#309026) isn't merged so currently has the fix there. Finally, [Lönn](https://github.com/CelestialCartographers/Loenn) works as expected, being the installation managed by the program. Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic executables olympus: fixed zenity argument olympus: bugfix add openssl to fhs olympus: fixed to use the default nfd instead of patched version olympus: changed location of ndf arg olympus: bugfix: add xdg-utils as runtime dependency to fix pop-up olympus: deleted zenity.patch Due to nfd lua package being fixed, this patch is no longer needed olympus: fix use of wrong nfd package olympus: bumped up version to 24.07.06.02 olympus: format files with nixfmt-rfc olympus: chores: comments, fixed lib conventions olympus: make wrappers properly, use standard build process, misc fixes olympus: update version, src; add updateScript olympus: avoid rec; use lib.getExe; remove redundant .out; minor changes olympus: use standard build process for dotnet; remove -nixos suffix in version; use new mono; add dotnet-runtime to fhs env olympus: 24.10.27.02 -> 24.11.23.01; fix version.txt; remove unnecessary dependencies; add miniinstaller and celeste wrapper; other misc change olympus-with-steam-run: init olympus: more flexible celeste wrapper olympus: accept emptry string and path as celeste wrapper; minor fix with lua cpath olympus: minor fix with lua cpath; add xdg-utils to path olympus: use standard lua-subprocess instead of fork olympus: make MiniInstaller be properly wrapped olympus: add option to skip handler olympus: tweaked platforms, tweaked miniinstaller-fhs olympus-with-steam-run: comment for reminder on fixing issues with relative paths olympus: removed extraneous package olympus: add extra wrapper options for mininstaller and loenn olympus: add more explicit comments, bump version olympus: fixed mismatched hash in olympus olympus: changed proprieties of miniinstaller-fhs (NixOS#336576) olympus: tweak miniinstallerWrapper

This is an attempt to package [Olympus](https://everestapi.github.io/), a GUI for installing Everest and managing Celeste mods. This is based on this [draft](NixOS#295258), with the authors permission. It maintains the previous issue of not being able to launch Steam versions of Celeste from the command line but that's not feasible without upstream changes. I only have to note that it has a popup complaining about finishing the installation but that's due to xdg-mime x-scheme-handler/everest not being set. Finally I want to note that it depends on lua51Packages.nfd, which is broken while [this](NixOS#309026) isn't merged so currently has the fix there. Finally, [Lönn](https://github.com/CelestialCartographers/Loenn) works as expected, being the installation managed by the program. Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic executables olympus: fixed zenity argument olympus: bugfix add openssl to fhs olympus: fixed to use the default nfd instead of patched version olympus: changed location of ndf arg olympus: bugfix: add xdg-utils as runtime dependency to fix pop-up olympus: deleted zenity.patch Due to nfd lua package being fixed, this patch is no longer needed olympus: fix use of wrong nfd package olympus: bumped up version to 24.07.06.02 olympus: format files with nixfmt-rfc olympus: chores: comments, fixed lib conventions olympus: make wrappers properly, use standard build process, misc fixes olympus: update version, src; add updateScript olympus: avoid rec; use lib.getExe; remove redundant .out; minor changes olympus: use standard build process for dotnet; remove -nixos suffix in version; use new mono; add dotnet-runtime to fhs env olympus: 24.10.27.02 -> 24.11.23.01; fix version.txt; remove unnecessary dependencies; add miniinstaller and celeste wrapper; other misc change olympus-with-steam-run: init olympus: more flexible celeste wrapper olympus: accept emptry string and path as celeste wrapper; minor fix with lua cpath olympus: minor fix with lua cpath; add xdg-utils to path olympus: use standard lua-subprocess instead of fork olympus: make MiniInstaller be properly wrapped olympus: add option to skip handler olympus: tweaked platforms, tweaked miniinstaller-fhs olympus-with-steam-run: comment for reminder on fixing issues with relative paths olympus: removed extraneous package olympus: add extra wrapper options for mininstaller and loenn olympus: add more explicit comments, bump version olympus: fixed mismatched hash in olympus olympus: changed proprieties of miniinstaller-fhs (NixOS#336576) olympus: tweak miniinstallerWrapper olympus: migrated to deps.json (NixOS#362278) olympus: remove meta.mainProgram explicitly (NixOS#358550)

This is an attempt to package [Olympus](https://everestapi.github.io/), a GUI for installing Everest and managing Celeste mods. This is based on this [draft](NixOS#295258), with the authors permission. It maintains the previous issue of not being able to launch Steam versions of Celeste from the command line but that's not feasible without upstream changes. I only have to note that it has a popup complaining about finishing the installation but that's due to xdg-mime x-scheme-handler/everest not being set. Finally I want to note that it depends on lua51Packages.nfd, which is broken while [this](NixOS#309026) isn't merged so currently has the fix there. Finally, [Lönn](https://github.com/CelestialCartographers/Loenn) works as expected, being the installation managed by the program. Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic executables olympus: fixed zenity argument olympus: bugfix add openssl to fhs olympus: fixed to use the default nfd instead of patched version olympus: changed location of ndf arg olympus: bugfix: add xdg-utils as runtime dependency to fix pop-up olympus: deleted zenity.patch Due to nfd lua package being fixed, this patch is no longer needed olympus: fix use of wrong nfd package olympus: bumped up version to 24.07.06.02 olympus: format files with nixfmt-rfc olympus: chores: comments, fixed lib conventions olympus: make wrappers properly, use standard build process, misc fixes olympus: update version, src; add updateScript olympus: avoid rec; use lib.getExe; remove redundant .out; minor changes olympus: use standard build process for dotnet; remove -nixos suffix in version; use new mono; add dotnet-runtime to fhs env olympus: 24.10.27.02 -> 24.11.23.01; fix version.txt; remove unnecessary dependencies; add miniinstaller and celeste wrapper; other misc change olympus-with-steam-run: init olympus: more flexible celeste wrapper olympus: accept emptry string and path as celeste wrapper; minor fix with lua cpath olympus: minor fix with lua cpath; add xdg-utils to path olympus: use standard lua-subprocess instead of fork olympus: make MiniInstaller be properly wrapped olympus: add option to skip handler olympus: tweaked platforms, tweaked miniinstaller-fhs olympus-with-steam-run: comment for reminder on fixing issues with relative paths olympus: removed extraneous package olympus: add extra wrapper options for mininstaller and loenn olympus: add more explicit comments, bump version olympus: fixed mismatched hash in olympus olympus: changed proprieties of miniinstaller-fhs (NixOS#336576) olympus: tweak miniinstallerWrapper olympus: migrated to deps.json (NixOS#362278) olympus: remove meta.mainProgram explicitly (NixOS#358550) olympus: bump to 24.12.28.01 changes to new install process of net8.0

This is an attempt to package [Olympus](https://everestapi.github.io/), a GUI for installing Everest and managing Celeste mods. This is based on this [draft](NixOS#295258), with the authors permission. It maintains the previous issue of not being able to launch Steam versions of Celeste from the command line but that's not feasible without upstream changes. I only have to note that it has a popup complaining about finishing the installation but that's due to xdg-mime x-scheme-handler/everest not being set. Finally I want to note that it depends on lua51Packages.nfd, which is broken while [this](NixOS#309026) isn't merged so currently has the fix there. Finally, [Lönn](https://github.com/CelestialCartographers/Loenn) works as expected, being the installation managed by the program. Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic executables olympus: fixed zenity argument olympus: bugfix add openssl to fhs olympus: fixed to use the default nfd instead of patched version olympus: changed location of ndf arg olympus: bugfix: add xdg-utils as runtime dependency to fix pop-up olympus: deleted zenity.patch Due to nfd lua package being fixed, this patch is no longer needed olympus: fix use of wrong nfd package olympus: bumped up version to 24.07.06.02 olympus: format files with nixfmt-rfc olympus: chores: comments, fixed lib conventions olympus: make wrappers properly, use standard build process, misc fixes olympus: update version, src; add updateScript olympus: avoid rec; use lib.getExe; remove redundant .out; minor changes olympus: use standard build process for dotnet; remove -nixos suffix in version; use new mono; add dotnet-runtime to fhs env olympus: 24.10.27.02 -> 24.11.23.01; fix version.txt; remove unnecessary dependencies; add miniinstaller and celeste wrapper; other misc change olympus-with-steam-run: init olympus: more flexible celeste wrapper olympus: accept emptry string and path as celeste wrapper; minor fix with lua cpath olympus: minor fix with lua cpath; add xdg-utils to path olympus: use standard lua-subprocess instead of fork olympus: make MiniInstaller be properly wrapped olympus: add option to skip handler olympus: tweaked platforms, tweaked miniinstaller-fhs olympus-with-steam-run: comment for reminder on fixing issues with relative paths olympus: removed extraneous package olympus: add extra wrapper options for mininstaller and loenn olympus: add more explicit comments, bump version olympus: fixed mismatched hash in olympus olympus: changed proprieties of miniinstaller-fhs (NixOS#336576) olympus: tweak miniinstallerWrapper olympus: migrated to deps.json (NixOS#362278) olympus: remove meta.mainProgram explicitly (NixOS#358550) olympus: bump to 24.12.28.01 changes to new install process of net8.0 olympus : format

This is an attempt to package [Olympus](https://everestapi.github.io/), a GUI for installing Everest and managing Celeste mods. This is based on this [draft](NixOS#295258), with the authors permission. It maintains the previous issue of not being able to launch Steam versions of Celeste from the command line but that's not feasible without upstream changes. I only have to note that it has a popup complaining about finishing the installation but that's due to xdg-mime x-scheme-handler/everest not being set. Finally I want to note that it depends on lua51Packages.nfd, which is broken while [this](NixOS#309026) isn't merged so currently has the fix there. Finally, [Lönn](https://github.com/CelestialCartographers/Loenn) works as expected, being the installation managed by the program. Ahorn is deprecated(in favor of Loenn) and it crashes over trying to run dynamic executables olympus: fixed zenity argument olympus: bugfix add openssl to fhs olympus: fixed to use the default nfd instead of patched version olympus: changed location of ndf arg olympus: bugfix: add xdg-utils as runtime dependency to fix pop-up olympus: deleted zenity.patch Due to nfd lua package being fixed, this patch is no longer needed olympus: fix use of wrong nfd package olympus: bumped up version to 24.07.06.02 olympus: format files with nixfmt-rfc olympus: chores: comments, fixed lib conventions olympus: make wrappers properly, use standard build process, misc fixes olympus: update version, src; add updateScript olympus: avoid rec; use lib.getExe; remove redundant .out; minor changes olympus: use standard build process for dotnet; remove -nixos suffix in version; use new mono; add dotnet-runtime to fhs env olympus: 24.10.27.02 -> 24.11.23.01; fix version.txt; remove unnecessary dependencies; add miniinstaller and celeste wrapper; other misc change olympus-with-steam-run: init olympus: more flexible celeste wrapper olympus: accept emptry string and path as celeste wrapper; minor fix with lua cpath olympus: minor fix with lua cpath; add xdg-utils to path olympus: use standard lua-subprocess instead of fork olympus: make MiniInstaller be properly wrapped olympus: add option to skip handler olympus: tweaked platforms, tweaked miniinstaller-fhs olympus-with-steam-run: comment for reminder on fixing issues with relative paths olympus: removed extraneous package olympus: add extra wrapper options for mininstaller and loenn olympus: add more explicit comments, bump version olympus: fixed mismatched hash in olympus olympus: changed proprieties of miniinstaller-fhs (NixOS#336576) olympus: tweak miniinstallerWrapper olympus: migrated to deps.json (NixOS#362278) olympus: remove meta.mainProgram explicitly (NixOS#358550) olympus: bump to 24.12.28.01 changes to new install process of net8.0 olympus : format olympus: changed install path, tweaked meta info

SigmaSquadron added the 5. scope: tracking Long-lived issue tracking long-term fixes or multiple sub-problems label Aug 23, 2024

FliegendeWurst added the 3.skill: trivial This is trivial to complete (typically find-and-replace) label Oct 14, 2024

tomodachi94 added the 3.skill: sprintable A larger issue which is split into distinct actionable tasks label Oct 16, 2024

This was referenced Nov 24, 2024

arduino: fix fhsenv version #358738

Merged

platformio: fix fhsenv version #359396

Merged

sparrow: fix fhsenv version #359397

Merged

steam: fix fhsenv version #359399

Closed

This was referenced Nov 28, 2024

appimageTools: use version #359930

Merged

bazel_7: fix fhsenv version #359958

Merged

arduino-cli: fix fhsenv version #359959

Merged

bitscope.*: fix fhsenv version #359960

Merged

android-studio: fix fhsenv version #359961

Merged

This was referenced Nov 28, 2024

sidequest: fix fhsenv version #359965

Merged

unigine-superposition: fix fhsenv version #359966

Merged

ciscoPacketTracer7: fix fhsenv version #360887

Merged

vscode: fix fhsenv version #360888

Merged

Pandapip1 changed the title ~~[Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version~~ [Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version cccccbukvviernhgdcgdcfddvhcndtijdirikdheeegc Dec 10, 2024

Pandapip1 changed the title ~~[Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version cccccbukvviernhgdcgdcfddvhcndtijdirikdheeegc~~ [Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version and/or meta Dec 10, 2024

Pandapip1 changed the title ~~[Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version and/or meta~~ [Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version Dec 10, 2024

Stunkymonkey mentioned this issue Dec 12, 2024

bolt-launcher: fix fhsenv version #364686

Merged

13 tasks

UlyssesZh mentioned this issue Dec 12, 2024

olympus: init at 24.12.28.01 #309327

Open

13 tasks

Pandapip1 closed this as completed Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tracking issue] `buildFHSEnv`-based derivations in nixpkgs often omit `version` #336576

[Tracking issue] `buildFHSEnv`-based derivations in nixpkgs often omit `version` #336576

Pandapip1 commented Aug 22, 2024 •

edited

Loading

tomodachi94 commented Oct 16, 2024 •

edited by Stunkymonkey

Loading

Stunkymonkey commented Nov 3, 2024

Pandapip1 commented Nov 3, 2024 •

edited

Loading

UlyssesZh commented Nov 23, 2024

Pandapip1 commented Nov 23, 2024 •

edited

Loading

Stunkymonkey commented Nov 26, 2024

Pandapip1 commented Nov 26, 2024

Stunkymonkey commented Nov 28, 2024

Stunkymonkey commented Dec 12, 2024

Pandapip1 commented Dec 13, 2024

[Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version #336576

[Tracking issue] buildFHSEnv-based derivations in nixpkgs often omit version #336576

Comments

Pandapip1 commented Aug 22, 2024 • edited Loading

Issue description

Examples

tomodachi94 commented Oct 16, 2024 • edited by Stunkymonkey Loading

Stunkymonkey commented Nov 3, 2024

Pandapip1 commented Nov 3, 2024 • edited Loading

UlyssesZh commented Nov 23, 2024

Pandapip1 commented Nov 23, 2024 • edited Loading

Stunkymonkey commented Nov 26, 2024

Pandapip1 commented Nov 26, 2024

Stunkymonkey commented Nov 28, 2024

Stunkymonkey commented Dec 12, 2024

Pandapip1 commented Dec 13, 2024

[Tracking issue] `buildFHSEnv`-based derivations in nixpkgs often omit `version` #336576

[Tracking issue] `buildFHSEnv`-based derivations in nixpkgs often omit `version` #336576

Pandapip1 commented Aug 22, 2024 •

edited

Loading

tomodachi94 commented Oct 16, 2024 •

edited by Stunkymonkey

Loading

Pandapip1 commented Nov 3, 2024 •

edited

Loading

Pandapip1 commented Nov 23, 2024 •

edited

Loading