Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] sydbox: 2.2.0 -> 3.28.3 #358071

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-24.11, triggered by a label in #356793.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@github-actions github-actions bot mentioned this pull request Nov 22, 2024
13 tasks
@ofborg ofborg bot requested review from getchoo and illdefined November 23, 2024 00:07
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 23, 2024
@illdefined
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 358071


x86_64-linux

✅ 2 packages built:
  • sydbox
  • sydbox.man

@illdefined
Copy link
Contributor

While this is a major version update, I believe that we should still include it in 24.11, considering that version 2.2.0 has been out of date for a while. Nothing in nixpkgs itself depends directly on sydbox, so this should not break anything.

Keeping the older release in 24.11 will produce far more headaches for users than updating to a recent version.

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 25, 2024
@wegank wegank merged commit 02dc6dd into release-24.11 Nov 26, 2024
22 of 23 checks passed
@wegank wegank deleted the backport-356793-to-release-24.11 branch November 26, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants