Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sydbox: 2.2.0 -> 3.28.3 #356793

Merged
merged 7 commits into from
Nov 22, 2024
Merged

sydbox: 2.2.0 -> 3.28.3 #356793

merged 7 commits into from
Nov 22, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Nov 17, 2024

Closes #356580

Changelog: https://gitlab.exherbo.org/sydbox/sydbox/-/blob/v3.28.3/ChangeLog.md?ref_type=tags#3283

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added the backport release-24.11 Backport PR automatically label Nov 17, 2024
@ofborg ofborg bot requested a review from illdefined November 18, 2024 07:59
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 18, 2024
@illdefined
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 356793

x86_64-linux

✅ 2 packages built:
  • sydbox
  • sydbox.man

illdefined
illdefined suggested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@illdefined illdefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of this update. I have had trouble getting it to build with Rust ≥ 1.80 for quite a while.

Successfully built on NixOS x86-64.

Minor nitpick: The previous home page at https://sydbox.exherbo.org is dead.

pkgs/by-name/sy/sydbox/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/sy/sydbox/package.nix Show resolved Hide resolved
illdefined
illdefined approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@illdefined illdefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that other reviewers might suggest squashing together a few of those commits, but I am quite okay with leaving them as individual commits.

Thanks again for taking care of this.

@getchoo getchoo added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 19, 2024
@ofborg ofborg bot requested a review from illdefined November 19, 2024 19:44
@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 356793 run on x86_64-linux 1

2 packages built:
  • sydbox
  • sydbox.man

@tomberek tomberek merged commit cb1e6e7 into NixOS:master Nov 22, 2024
29 of 30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 22, 2024
Merged
1 task
@getchoo getchoo deleted the pkgs/sydbox/3.28.2 branch November 22, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illdefined illdefined illdefined approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update request: sydbox 1-2.2.0 → 3.28.2
3 participants
@getchoo @illdefined @tomberek