Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/darkhttpd: change listening address default to ::1 #353402

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nixos/modules/services/web-servers/darkhttpd.nix
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ in {
};

address = mkOption {
default = "127.0.0.1";
default = "::1";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default = "::1";
default = if config.networking.enableIPv6 then "::1" else "127.0.0.1";
defaultText = lib.literalExpresison ''if config.networking.enableIPv6 then "::1" else "127.0.0.1"'';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we would also have to adjust:

We unconditionally pass --ipv6 to the binary

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 probably, I am unsure

type = str;
description = ''
Address to listen on.
Pass `all` to listen on all interfaces.
Pass `::` to listen on all interfaces.
'';
};

Expand Down