nixos/darkhttpd: change listening address default to ::1 #353402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We unconditionally pass --ipv6 to the binary. In older versions, setting both --addr 127.0.0.1 and --ipv6 resulted in listening on [::], a potential security issue. On the other hand, the binary started. With the current version however, --ipv6 implies an IPv6 address in --addr resulting in a crash with: "darkhttpd: malformed --addr argument" While this commit is technically a BC-break, it should be harmless as existing users either do not explicitly set the address and the server refuses the start (making this change rather a fix) or they set the address and are therefore unaffected.
github-actions
bot
added
6.topic: nixos
patka-123
approved these changes
Nov 3, 2024
This does not seem to have ever been intended, it was probably caused by the same parsing issue as described in commit abdadde Listening on [::] makes darkhttpd see IPv4 connections under ::ffff:a.b.c.d
bobvanderlinden
approved these changes
Nov 3, 2024
wegank
added
the
12.approvals: 2
ofborg
bot
added
10.rebuild-darwin: 0
FliegendeWurst
approved these changes
Nov 19, 2024
wegank
added
12.approvals: 3+
| @@ -27,11 +27,11 @@ in { | |||
| }; | |||
|
|
|||
| address = mkOption { | |||
| default = "127.0.0.1"; | |||
| default = "::1"; | |||
There was a problem hiding this comment.
Suggested change
| default = "::1"; | |
| default = if config.networking.enableIPv6 then "::1" else "127.0.0.1"; | |
| defaultText = lib.literalExpresison ''if config.networking.enableIPv6 then "::1" else "127.0.0.1"''; |
There was a problem hiding this comment.
Then we would also have to adjust:
We unconditionally pass --ipv6 to the binary
There was a problem hiding this comment.
🤔 probably, I am unsure
wegank
added
12.approvals: 2
|
@bobvanderlinden @SuperSandro2000 Oh I completely forgot about machines without IPv6. In such a case I don't think we should detect IPv6 status by the I therefore propose to add another config options for darkhttpd to decide whether to enable IPv6 support. It would default to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We unconditionally pass --ipv6 to the binary. In older versions, setting both --addr 127.0.0.1 and --ipv6 resulted in listening on [::], a potential security issue. On the other hand, the binary started.
With the current version however, --ipv6 implies an IPv6 address in --addr resulting in a crash with: "darkhttpd: malformed --addr argument"
While this commit is technically a BC-break, it should be harmless as existing users either do not explicitly set the address and the server refuses the start (making this change rather a fix) or they set the address and are therefore unaffected.
The above excerpt from the commit message shall summarize the changes well. I just want to add that the this is not a BC-break, this is a bug fix shall qualify it for merging despite the freeze in #339153.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.