Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivyterm: fix hash #352350

Merged
merged 1 commit into from
Oct 30, 2024
Merged

ivyterm: fix hash #352350

merged 1 commit into from
Oct 30, 2024

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 30, 2024

Things done

cc @vcunat

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@vcunat
Copy link
Member

vcunat commented Oct 30, 2024

Any idea why the hash was wrong?

@vcunat vcunat requested a review from genga898 October 30, 2024 11:01
@GaetanLepage
Copy link
Contributor Author

Any idea why the hash was wrong?

Not really... I'm wondering how I could have been tricked by the FOD, but I have no clue.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352350


x86_64-linux

✅ 1 package built:
  • ivyterm

aarch64-linux

✅ 1 package built:
  • ivyterm

x86_64-darwin

✅ 1 package built:
  • ivyterm

aarch64-darwin

✅ 1 package built:
  • ivyterm

@genga898
Copy link
Contributor

Weird, locally it builds with both hashes on my end.

@vcunat
Copy link
Member

vcunat commented Oct 30, 2024

You have it cached apparently. But that would mean the FOD is non-deterministic. I suggest to build ivyterm.src in both cases (i.e. find the paths) and find what differs.

@genga898
Copy link
Contributor

Did a bit of garbage collection and seems like the hash changed, the new one is correct.

Copy link
Contributor

@zi3m5f zi3m5f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed rev without hash in the original PR #350745 here ;)

The new hash is correct 👍

@vcunat vcunat merged commit 0cd15ae into NixOS:master Oct 30, 2024
40 of 41 checks passed
@GaetanLepage GaetanLepage deleted the ivyterm branch October 30, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants