Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivyterm: init at 0-unstable-2024-10-23 #350745

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

genga898
Copy link
Contributor

Add ivyterm to nixpkgs, a gtk4 based terminal editor with tmux sessions by default

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

pkgs/by-name/iv/ivyterm/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/iv/ivyterm/package.nix Show resolved Hide resolved
@genga898 genga898 changed the title ivyterm: init at unstable-2024-10-23 ivyterm: init at 0-unstable-2024-10-23 Oct 28, 2024
pkgs/by-name/iv/ivyterm/package.nix Outdated Show resolved Hide resolved
ivyterm: update

ivyterm: update cargoHash and rev

ivyterm: remove doCheckInstall
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350745


x86_64-linux

✅ 1 package built:
  • ivyterm

aarch64-linux

✅ 1 package built:
  • ivyterm

x86_64-darwin

✅ 1 package built:
  • ivyterm

aarch64-darwin

✅ 1 package built:
  • ivyterm

@GaetanLepage GaetanLepage merged commit e3cde0b into NixOS:master Oct 29, 2024
27 of 28 checks passed
@vcunat
Copy link
Member

vcunat commented Oct 30, 2024

The source hash doesn't match on Hydra, and ofBorg here complained about the same (and I confirmed locally). It's suspicious.

@GaetanLepage
Copy link
Contributor

The source hash doesn't match on Hydra, and ofBorg here complained about the same (and I confirmed locally). It's suspicious.

Indeed, sorry for missing that.
Fixed in #352350.

@zi3m5f zi3m5f mentioned this pull request Oct 30, 2024
13 tasks
@genga898 genga898 deleted the ivyterm branch November 7, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants