Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labwc: 0.8.0 -> 0.8.1 #351990

Merged
merged 2 commits into from
Nov 3, 2024
Merged

labwc: 0.8.0 -> 0.8.1 #351990

merged 2 commits into from
Nov 3, 2024

Conversation

zi3m5f
Copy link
Contributor

@zi3m5f zi3m5f commented Oct 28, 2024 •
edited
Loading

needs libsfdo so added commit libsfdo: init at 0.1.3 of closed #351987
https://github.com/labwc/labwc/blob/master/NEWS.md#081

  • versionCheckHook works
  • ldd shows libsfdo gets linked:

ldd /nix/store/kk2lcg93g4m6s0snyhyksvb7q14g59lr-labwc-0.8.1/bin/labwc |grep sfdo
libsfdo-basedir.so.0 => /nix/store/w7pp98frg8762cjfw4idkfflcrnsrd41-libsfdo-0.1.3/lib/libsfdo-basedir.so.0 (0x00007f1ea1f76000)
libsfdo-desktop.so.0 => /nix/store/w7pp98frg8762cjfw4idkfflcrnsrd41-libsfdo-0.1.3/lib/libsfdo-desktop.so.0 (0x00007f1ea1f6b000)
libsfdo-icon.so.0 => /nix/store/w7pp98frg8762cjfw4idkfflcrnsrd41-libsfdo-0.1.3/lib/libsfdo-icon.so.0 (0x00007f1ea1f60000)
libsfdo-desktop-file.so.0 => /nix/store/w7pp98frg8762cjfw4idkfflcrnsrd41-libsfdo-0.1.3/lib/libsfdo-desktop-file.so.0 (0x00007f1ea0cdb000)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zi3m5f zi3m5f mentioned this pull request Oct 28, 2024
Closed
13 tasks
@zi3m5f zi3m5f force-pushed the labwc-update branch 2 times, most recently from c00a649 to dcfb1be Compare October 28, 2024 22:54
@zi3m5f zi3m5f added 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed 9.needs: package (new) This needs a new package to be added labels Oct 28, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 29, 2024
@ofborg ofborg bot requested a review from AndersonTorres October 29, 2024 02:39
@zi3m5f zi3m5f marked this pull request as ready for review October 29, 2024 07:09
@zi3m5f zi3m5f removed 9.needs: package (new) This needs a new package to be added 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed labels Oct 29, 2024
@Scrumplex
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351990

x86_64-linux

✅ 4 packages built:
  • labwc
  • labwc.doc
  • labwc.man
  • libsfdo

Scrumplex
Scrumplex approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 1, 2024
RicArch97
RicArch97 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@RicArch97 RicArch97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!

jopejoe1
jopejoe1 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@jopejoe1 jopejoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351990

x86_64-linux

✅ 4 packages built:
  • labwc
  • labwc.doc
  • labwc.man
  • libsfdo

@jopejoe1 jopejoe1 merged commit 2860a2e into NixOS:master Nov 3, 2024
44 checks passed
@zi3m5f zi3m5f deleted the labwc-update branch November 9, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RicArch97 RicArch97 RicArch97 approved these changes

@jopejoe1 jopejoe1 jopejoe1 approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zi3m5f @Scrumplex @jopejoe1 @RicArch97 @wegank