Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsfdo: init at 0.1.3 #351987

Closed
wants to merge 1 commit into from
Closed

libsfdo: init at 0.1.3 #351987

wants to merge 1 commit into from

Conversation

zi3m5f
Copy link
Contributor

@zi3m5f zi3m5f commented Oct 28, 2024

Updating labwc to 0.8.1 (#351990) requires libsfdo see labwc/NEWS.md and:

Run-time dependency libsfdo-basedir found: NO (tried pkgconfig and cmake)

Tested by building labwc-0.8.1 with this.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zi3m5f zi3m5f mentioned this pull request Oct 28, 2024
15 tasks
@zi3m5f
Copy link
Contributor Author

zi3m5f commented Oct 28, 2024

@AndersonTorres would you be interested in reviewing this PR? (being a prerequisite for labwc-0.8.1)
And should I add you as maintainer? Because labwc will be as of now the only package depending on libsfdo.

@AndersonTorres
Copy link
Member

Close this PR, given that the dependency is not shared among other projects.

@zi3m5f zi3m5f closed this Oct 29, 2024
@zi3m5f zi3m5f deleted the libsfdo-init branch October 29, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants