pytubefix: 6.4.2 -> 8.0.0 #351298
Closed
pytubefix: 6.4.2 -> 8.0.0 #351298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegank
added
the
2.status: merge conflict
benaryorg
added a commit
to benaryorg/nixpkgs
that referenced
this pull request
Nov 7, 2024
Two kinds of test failures show in Hydra: 1. tests failing due to lack of DNS 1. tests genuinely failing The latter one has an open PR, which will likely fix this for an upcoming version. The first one now has an open issue upstream and which may or may not be fixed. Disabling those tests has been suggested in NixOS#351298 already, which ended up not being merged. Signed-off-by: benaryorg <[email protected]>
13 tasks
benaryorg
added a commit
to benaryorg/nixpkgs
that referenced
this pull request
Nov 7, 2024
Two kinds of test failures show in Hydra: 1. tests failing due to lack of DNS 1. tests genuinely failing The latter one has an open PR, which will likely fix this for an upcoming version, with the patch included here. The first one now has an open issue upstream and which may or may not be fixed. Disabling those tests has been suggested in NixOS#351298 already, which ended up not being merged. Signed-off-by: benaryorg <[email protected]>
benaryorg
added a commit
to benaryorg/nixpkgs
that referenced
this pull request
Nov 8, 2024
Two kinds of test failures show in Hydra: 1. tests failing due to lack of DNS 1. tests genuinely failing The latter one has an open PR, which will likely fix this for an upcoming version, with the patch included here. The first one now has an open issue upstream and which may or may not be fixed. Disabling those tests has been suggested in NixOS#351298 already, which ended up not being merged. Signed-off-by: benaryorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog/diffs JuanBindez/pytubefix@v6.4.2...v8.0.0
Things done
updated package, made changes to how python package were called, original syntax wouldnt build with new version. reason unknown.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)