Skip to content

Commit

Permalink
python3Packages.pytubefix: test failures
Browse files Browse the repository at this point in the history
Two kinds of test failures show in Hydra:

1. tests failing due to lack of DNS
1. tests genuinely failing

The latter one has an open PR, which will likely fix this for an upcoming version, with the patch included here.
The first one now has an open issue upstream and which may or may not be fixed.
Disabling those tests has been suggested in NixOS#351298 already, which ended up not being merged.

Signed-off-by: benaryorg <[email protected]>
  • Loading branch information
benaryorg committed Nov 7, 2024
1 parent ba54c36 commit 3ce74fd
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions pkgs/development/python-modules/pytubefix/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
lib,
buildPythonPackage,
fetchFromGitHub,
fetchpatch,
setuptools,
pytestCheckHook,
}:
Expand All @@ -22,6 +23,13 @@ buildPythonPackage rec {

nativeCheckInputs = [ pytestCheckHook ];

patches = [
(fetchpatch {
url = "https://github.com/JuanBindez/pytubefix/commit/25a90fd3552c85944e140e8ba65ef0ded935dcf0.patch";
hash = "sha256-RXVA6XTrnI3N6/wYm8hSQAg0zXPWMdSairnKuCNlZBs=";
})
];

disabledTestPaths = [
# require network access
"tests/test_captions.py"
Expand All @@ -31,6 +39,7 @@ buildPythonPackage rec {
"tests/test_main.py"
"tests/test_query.py"
"tests/test_streams.py"
"tests/contrib/test_playlist.py"
];

pythonImportsCheck = [ "pytubefix" ];
Expand Down

0 comments on commit 3ce74fd

Please sign in to comment.