Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresqlPackages.sqlite_fdw: init at 2.4.0 #350353

Merged
merged 1 commit into from
Nov 17, 2024
Merged

postgresqlPackages.sqlite_fdw: init at 2.4.0 #350353

merged 1 commit into from
Nov 17, 2024
+36 −0

Conversation

apfelkuchen6
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from thoughtpolice October 21, 2024 21:31
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Oct 22, 2024
FliegendeWurst
FliegendeWurst requested changes Nov 10, 2024
View reviewed changes
pkgs/servers/sql/postgresql/ext/sqlite_fdw.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/sqlite_fdw.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/sqlite_fdw.nix Outdated Show resolved Hide resolved
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 10, 2024
@nix-owners nix-owners bot requested review from Ma27 and wolfgangwalther November 10, 2024 19:59
@apfelkuchen6
Copy link
Contributor Author

@ofborg build postgresql12Packages.sqlite_fdw postgresql13Packages.sqlite_fdw postgresql14Packages.sqlite_fdw postgresql15Packages.sqlite_fdw postgresql16Packages.sqlite_fdw

Ma27
Ma27 requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then remove the whole install phase, this should work out of the box

Also replace stdenv.mkDerivation with buildPostgresqlExtension.

Blocking to make sure nobody merges it before.

@wolfgangwalther wolfgangwalther mentioned this pull request Nov 11, 2024
Merged
13 tasks
@apfelkuchen6 apfelkuchen6 force-pushed the sqlite_fdw branch 3 times, most recently from 3626ccc to 2fdb191 Compare November 14, 2024 19:12
@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 350353 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • postgresql17JitPackages.sqlite_fdw
  • postgresql17Packages.sqlite_fdw
10 packages built:
  • postgresql12JitPackages.sqlite_fdw
  • postgresql12Packages.sqlite_fdw
  • postgresql13JitPackages.sqlite_fdw
  • postgresql13Packages.sqlite_fdw
  • postgresql14JitPackages.sqlite_fdw
  • postgresql14Packages.sqlite_fdw
  • postgresql15JitPackages.sqlite_fdw
  • postgresql15Packages.sqlite_fdw
  • postgresql16JitPackages.sqlite_fdw
  • postgresql16Packages.sqlite_fdw

@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 350353 run on aarch64-darwin 1

2 packages marked as broken and skipped:
  • postgresql17JitPackages.sqlite_fdw
  • postgresql17Packages.sqlite_fdw
10 packages built:
  • postgresql12JitPackages.sqlite_fdw
  • postgresql12Packages.sqlite_fdw
  • postgresql13JitPackages.sqlite_fdw
  • postgresql13Packages.sqlite_fdw
  • postgresql14JitPackages.sqlite_fdw
  • postgresql14Packages.sqlite_fdw
  • postgresql15JitPackages.sqlite_fdw
  • postgresql15Packages.sqlite_fdw
  • postgresql16JitPackages.sqlite_fdw
  • postgresql16Packages.sqlite_fdw

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 15, 2024
@Ma27 Ma27 merged commit a0a5177 into NixOS:master Nov 17, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst requested changes

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@Ma27 Ma27 Ma27 approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person awaiting_changes (old Marvin label, do not use)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apfelkuchen6 @wolfgangwalther @Ma27 @FliegendeWurst @wegank