Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pg-semver: init at 0.40.0 #341014

Merged
merged 2 commits into from
Nov 17, 2024
Merged

pg-semver: init at 0.40.0 #341014

merged 2 commits into from
Nov 17, 2024

Conversation

grgi
Copy link
Contributor

@grgi grgi commented Sep 10, 2024 •
edited
Loading

Description of changes

New PostgreSQL extension: A semantic version data type for PostgreSQL .

https://github.com/theory/pg-semver

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@grgi grgi requested a review from thoughtpolice as a code owner September 10, 2024 13:31
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 10, 2024
@grgi grgi force-pushed the master branch 2 times, most recently from 0574acf to a04e24f Compare September 10, 2024 13:37
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 10, 2024
Bot-wxt1221
Bot-wxt1221 suggested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome the nixpkgs.

pkgs/servers/sql/postgresql/ext/pg-semver.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/pg-semver.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/pg-semver.nix Outdated Show resolved Hide resolved
pkgs/servers/sql/postgresql/ext/pg-semver.nix Outdated Show resolved Hide resolved
callumio
callumio suggested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@callumio callumio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit name for adding yourself as a maintainer should be maintainers: add grgi

@grgi
Copy link
Contributor Author

grgi commented Sep 10, 2024

The commit name for adding yourself as a maintainer should be maintainers: add grgi

Thanks, I've been looking for a template message but I must have missed it. It's changed now.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Sep 10, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Sep 10, 2024
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Sep 22, 2024
@grgi
Copy link
Contributor Author

grgi commented Oct 20, 2024

@thoughtpolice Is something still missing?

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Nov 10, 2024
wolfgangwalther
wolfgangwalther requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same case as #350353 - let's wait for the proper replacement for installPhase.

@Ma27

@Ma27
Copy link
Member

Ma27 commented Nov 13, 2024

Same case as #350353 - let's wait for the proper replacement for installPhase.

Agreed.

@nix-owners nix-owners bot requested a review from Ma27 November 14, 2024 21:40
@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 341014 run on x86_64-linux 1

12 packages built:
  • postgresql12JitPackages.pg-semver
  • postgresql12Packages.pg-semver
  • postgresql13JitPackages.pg-semver
  • postgresql13Packages.pg-semver
  • postgresql14JitPackages.pg-semver
  • postgresql14Packages.pg-semver
  • postgresql15JitPackages.pg-semver
  • postgresql15Packages.pg-semver
  • postgresql16JitPackages.pg-semver
  • postgresql16Packages.pg-semver
  • postgresql17JitPackages.pg-semver
  • postgresql17Packages.pg-semver

@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 341014 run on aarch64-darwin 1

12 packages built:
  • postgresql12JitPackages.pg-semver
  • postgresql12Packages.pg-semver
  • postgresql13JitPackages.pg-semver
  • postgresql13Packages.pg-semver
  • postgresql14JitPackages.pg-semver
  • postgresql14Packages.pg-semver
  • postgresql15JitPackages.pg-semver
  • postgresql15Packages.pg-semver
  • postgresql16JitPackages.pg-semver
  • postgresql16Packages.pg-semver
  • postgresql17JitPackages.pg-semver
  • postgresql17Packages.pg-semver

@wolfgangwalther
Copy link
Contributor

@grgi note that the signature on your commit says this in the UI here:

This commit was signed with the committer's verified signature. The key has expired.

(emphasis mine)

@grgi
Copy link
Contributor Author

grgi commented Nov 15, 2024

@grgi note that the signature on your commit says this in the UI here:

This commit was signed with the committer's verified signature. The key has expired.

(emphasis mine)

Thank you! I'll update the key.

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Nov 15, 2024
@Ma27 Ma27 merged commit da5c259 into NixOS:master Nov 17, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst left review comments

@callumio callumio callumio requested changes

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 approved these changes

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@Ma27 Ma27 Ma27 approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@grgi @Ma27 @wolfgangwalther @FliegendeWurst @callumio @Bot-wxt1221 @wegank @NixOSInfra