Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zola to 0.19.1 — requires Rust 1.79 #330052

Closed
wants to merge 1 commit into from

Conversation

opeik
Copy link

@opeik opeik commented Jul 26, 2024

Description of changes

  • Updates zola to version 0.19.1
  • Unable to build yet since Rust 1.79 is required by multiple dependencies
    • Builds and runs correctly via rust-overlay generated Rust 1.79 toolchain
       > ++ env CC_AARCH64_APPLE_DARWIN=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/cc CXX_AARCH64_APPLE_DARWIN=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/c++ CARGO_TARGET_AARCH64_APPLE_DARWIN_LINKER=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/cc CC_AARCH64_APPLE_DARWIN=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/cc CXX_AARCH64_APPLE_DARWIN=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/c++ CARGO_TARGET_AARCH64_APPLE_DARWIN_LINKER=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/cc CARGO_BUILD_TARGET=aarch64-apple-darwin HOST_CC=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/cc HOST_CXX=/nix/store/k8mrxviw965lv59hqbln3297jwfffm2w-clang-wrapper-16.0.6/bin/c++ cargo build -j 8 --target aarch64-apple-darwin --offline --profile release
       > warning: `/private/tmp/nix-build-zola-0.19.1.drv-0/.cargo/config` is deprecated in favor of `config.toml`
       > note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
       > warning: `/private/tmp/nix-build-zola-0.19.1.drv-0/.cargo/config` is deprecated in favor of `config.toml`
       > note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
       > error: rustc 1.78.0 is not supported by the following packages:
       >   [email protected] requires rustc 1.79
       >   [email protected] requires rustc 1.79
       > Either upgrade rustc or select compatible dependency versions with
       > `cargo update <name>@<current-ver> --precise <compatible-ver>`
       > where `<compatible-ver>` is the latest version supporting rustc 1.78.0
       >
       For full logs, run 'nix log /nix/store/fl860ma87ym7i9zqinc550hqf3yzqarm-zola-0.19.1.drv'.

Things done

  • Updated pkgs/by-name/zo/zola/package.nix

  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.


Add a 👍 reaction to pull requests you find important.

@opeik opeik changed the title Bump zola to 0.19.1 — requires Rust Bump zola to 0.19.1 — requires Rust 1.79 Jul 26, 2024
@donovanglover
Copy link
Member

Duplicate of #325370

@donovanglover donovanglover marked this as a duplicate of #325370 Jul 26, 2024
@donovanglover
Copy link
Member

Closing in favor of the older PR

@opeik opeik deleted the opeik/bump-zola branch August 14, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants