-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zola: 0.18 -> 0.19.1 #325370
zola: 0.18 -> 0.19.1 #325370
Conversation
So let's wait an update on Rust instead. Close or at least put it on draft. |
I blame the Nix Matrix room |
Show them the log :) https://github.com/NixOS/nixpkgs/actions/runs/9830902488/job/27137607321?pr=325370
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct way to pull in dependencies.
From what I can gather from this pr, rust 1.79 has already hit master. I haven't personally verified it but do check this out.
In mere two days?? |
hah, just realized both that it targeted staging and that it was only 2 days ago. Good news for OP then, it'll roll in soon, can leave PR open but remove the IFDs |
didn't work when i tried it, but maybe that's because I was doing the build wrong. |
Let's wait a bit more. |
Skipping 0.19.0 because it had a bug in `zola watch`.
44a4676
to
fcee118
Compare
Y'all want me to mark it as draft, or do you have a "blocked" label, or what? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Waiting on Rust 1.79 to hit mainline before it can be merged. Congrats on the new PR!
We usually ask to mark as draft to indicate a "waiting state". |
1.79 is already in staging-next, so this could be merged there now. (But if you do change the base branch, make sure you follow the documentation for how to do so without accidentally mass pinging people.) |
rust 1.79 is on master now Result of 1 package built:
|
@SIGSTACKFAULT feel free to undraft. |
Superseded by #332403. |
@AndersonTorres sorry, wasn't checking GH due to finals |
Description of changes
My first nixpkgs contribution so please be gentle. Skipping 0.19 because it had a bug in
zola watch
.Requires Rust 1.79 #320250.
Changelog: here
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.