Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/qgroundcontrol: init module #325880

Merged
merged 3 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions nixos/doc/manual/release-notes/rl-2411.section.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@

- [Flood](https://flood.js.org/), a beautiful WebUI for various torrent clients. Available as [services.flood](options.html#opt-services.flood).

- [QGroundControl], a ground station support and configuration manager for the PX4 and APM Flight Stacks. Available as [programs.qgroundcontrol](options.html#opt-programs.qgroundcontrol.enable).

- [Eintopf](https://eintopf.info), community event and calendar web application. Available as [services.eintopf](options.html#opt-services.eintopf).

- [Renovate](https://github.com/renovatebot/renovate), a dependency updating tool for various git forges and language ecosystems. Available as [services.renovate](#opt-services.renovate.enable).
Expand Down
1 change: 1 addition & 0 deletions nixos/modules/module-list.nix
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@
./programs/projecteur.nix
./programs/proxychains.nix
./programs/qdmr.nix
./programs/qgroundcontrol.nix
./programs/qt5ct.nix
./programs/quark-goldleaf.nix
./programs/regreet.nix
Expand Down
53 changes: 53 additions & 0 deletions nixos/modules/programs/qgroundcontrol.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
{
Pandapip1 marked this conversation as resolved.
Show resolved Hide resolved
config,
lib,
pkgs,
...
}:

let
cfg = config.programs.qgroundcontrol;
in
{

options = {
programs.qgroundcontrol = {
enable = lib.mkEnableOption "qgroundcontrol";

package = lib.mkPackageOption pkgs "qgroundcontrol" {};

blacklistModemManagerFromTTYUSB = lib.mkOption {
type = lib.types.bool;
default = true;
description = ''
Disallow ModemManager from interfering with serial connections that QGroundControl might use.

Note that if you use a modem that's connected via USB, you might want to disable this option.
'';
};
};
};

config = lib.mkIf cfg.enable {
# ModemManager is known to interfere with serial connections;
# QGC recommends disabling it, but we don't want to if we can avoid it
# Instead, we blacklist tty devices using udev rules, which is a more targeted approach
services.udev = lib.mkIf cfg.blacklistModemManagerFromTTYUSB {
enable = true;
extraRules = ''
# nixos/qgroundcontrol: Blacklist ttyUSB devices from ModemManager
SUBSYSTEM=="tty", KERNEL=="ttyUSB*", ENV{ID_MM_DEVICE_IGNORE}="1"
'';
};

# Security wrapper
security.wrappers.qgroundcontrol = {
source = lib.getExe cfg.package;
owner = "root"; # Sensible default; not setuid so this is not a security risk
group = "tty";
setgid = true;
};
};

meta.maintainers = pkgs.qgroundcontrol.meta.maintainers;
}
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ stdenv.mkDerivation rec {
homepage = "http://qgroundcontrol.com/";
license = licenses.gpl3Plus;
platforms = platforms.linux;
maintainers = with maintainers; [ lopsided98 ];
maintainers = with maintainers; [ lopsided98 pandapip1 ];
mainProgram = "QGroundControl";
};
}