Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/qgroundcontrol: init module #325880

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Jul 9, 2024

Description of changes

Adds a nixos module that installs and sets recommended settings for qgroundcontrol.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 9, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 9, 2024
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jul 9, 2024
nixos/modules/programs/qgroundcontrol.nix Outdated Show resolved Hide resolved
nixos/modules/programs/qgroundcontrol.nix Outdated Show resolved Hide resolved
nixos/modules/programs/qgroundcontrol.nix Outdated Show resolved Hide resolved
nixos/modules/programs/qgroundcontrol.nix Show resolved Hide resolved
@Pandapip1 Pandapip1 force-pushed the init-nixos-qgroundcontrol branch 2 times, most recently from 627e649 to 7b96824 Compare July 9, 2024 21:22
@Pandapip1 Pandapip1 requested a review from lopsided98 July 9, 2024 21:23
@github-actions github-actions bot added 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Jul 9, 2024
@Pandapip1 Pandapip1 requested a review from h7x4 July 9, 2024 21:26
nixos/modules/programs/qgroundcontrol.nix Outdated Show resolved Hide resolved
nixos/modules/programs/qgroundcontrol.nix Outdated Show resolved Hide resolved
nixos/modules/programs/qgroundcontrol.nix Outdated Show resolved Hide resolved
nixos/modules/programs/qgroundcontrol.nix Outdated Show resolved Hide resolved
@Pandapip1 Pandapip1 force-pushed the init-nixos-qgroundcontrol branch from 4b3ca30 to e922115 Compare July 9, 2024 22:19
@Pandapip1 Pandapip1 requested a review from h7x4 July 9, 2024 22:19
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but I think the diff looks fine. Nice 👍

@h7x4
Copy link
Member

h7x4 commented Jul 9, 2024

I'll just leave a proper comment here that I'd like @lopsided98 to verify that they want to partake in maintainership of the module, so it doesn't get lost inbetween resolved comments.

@lopsided98
Copy link
Contributor

I guess I'm fine with being a maintainer, although I don't see myself needing this module.

@h7x4 h7x4 merged commit 290b315 into NixOS:master Jul 10, 2024
25 of 27 checks passed
@Pandapip1 Pandapip1 deleted the init-nixos-qgroundcontrol branch July 10, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants