doc: warn against zero-byte or missing shell completion files #325591
+13
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: documentation
LeSuisse
reviewed
Jul 8, 2024
| @@ -25,3 +25,17 @@ The `installShellCompletion` function takes one or more paths to shell completio | |||
| ''; | |||
There was a problem hiding this comment.
L20 to 24 should probably be removed in favor of the next paragraph?
There was a problem hiding this comment.
Yeah, makes sense. Removed the duplicated code and moved the line about fifo/named fd closer to its actual example.
ofborg
bot
added
10.rebuild-darwin: 0
SFrijters
force-pushed
the
install-shell-completion-doc
branch
from
d952696 to
259d274
Compare
13 tasks
LeSuisse
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Clarify common failure mode of #289517 .
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.