docs/installShellFiles: document how to not break cross-compilation #326016
Conversation
github-actions
bot
added
the
8.has: documentation
Mic92
force-pushed
the
install-shell-files
branch
from
c3ff62c to
cde8053
Compare
ofborg
bot
added
the
6.topic: cross-compilation
Mic92
force-pushed
the
install-shell-files
branch
from
cde8053 to
9d7fcba
Compare
Mic92
force-pushed
the
install-shell-files
branch
from
9d7fcba to
a2b9db8
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
PR on the same subject #325591 |
| installShellCompletion --cmd foobar \ | ||
| --bash <($out/bin/foobar --bash-completion) \ | ||
| --fish <($out/bin/foobar --fish-completion) \ | ||
| --zsh <($out/bin/foobar --zsh-completion) | ||
| ''; | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Some people have spoken out against this solution before #316749 (comment) and below.
There was a problem hiding this comment.
I cannot quite follow the reasoning in this thread though. Qemu is not that bad to have in your build closure. It should be already compiled anyway. But I think it's harder to test, so I personally prefer if contributor at least remove this completion for cross compilation.
There was a problem hiding this comment.
I don't have a strong opinion either way, just trying to tie all the discussions in various places together (and hopefully the bikeshedding will converge on something).
Separate question: why is this in preFixup? Is that because it's before wrapping happens?
There was a problem hiding this comment.
I don't have a strong opinion here. I let you let write the documentation than.
Just ping me on the review.
|
Also linking to discussion in #308283 . |
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.