Proposal to refactor Reader and Type classes #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irineu333
changed the title
Irineu333
force-pushed
the
refactor/improve-type-class
branch
4 times, most recently
from
0c33362 to
0a0f8f3
Compare
Irineu333
commented
Nov 20, 2023
Irineu333
commented
Nov 20, 2023
Irineu333
commented
Nov 20, 2023
Irineu333
commented
Nov 20, 2023
app/src/main/java/com/neo/speaktouch/utils/extension/AccessibilityNodeInfo.kt
Show resolved
Hide resolved
Irineu333
commented
Nov 20, 2023
Irineu333
commented
Nov 20, 2023
Irineu333
force-pushed
the
refactor/improve-type-class
branch
3 times, most recently
from
80a6bc7 to
aa0e3d5
Compare
Irineu333
force-pushed
the
refactor/improve-type-class
branch
5 times, most recently
from
3d9c9eb to
30e2263
Compare
PatrykMis
force-pushed
the
feature/ISSUE#97-improve-reader-class
branch
from
9c9774b to
3bb9d58
Compare
PatrykMis
force-pushed
the
refactor/improve-type-class
branch
from
45f8a63 to
adcbfba
Compare
PatrykMis
force-pushed
the
feature/ISSUE#97-improve-reader-class
branch
from
3bb9d58 to
956649b
Compare
PatrykMis
approved these changes
Nov 30, 2023
Irineu333
force-pushed
the
refactor/improve-type-class
branch
2 times, most recently
from
8eb3d80 to
ae6d8fd
Compare
PatrykMis
force-pushed
the
feature/ISSUE#97-improve-reader-class
branch
from
956649b to
3bb9d58
Compare
Irineu333
force-pushed
the
refactor/improve-type-class
branch
from
ae6d8fd to
41970d9
Compare
Irineu333
force-pushed
the
refactor/improve-type-class
branch
from
41970d9 to
c09dccb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A proposal to improve the Type class. It also extracts state and type reading logic for extensions.
I didn't send it directly in a commit to #100, because it's a proposal. We may not go through with it.
Improvements
Fixes