chore: add reminder for future improvements

NeoA11y · Nov 29, 2023 · 45f8a63 · 45f8a63
1 parent 6fc6fee
commit 45f8a63
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/app/src/main/java/com/neo/speaktouch/model/Type.kt b/app/src/main/java/com/neo/speaktouch/model/Type.kt
@@ -80,6 +80,8 @@ sealed class Type {
             // View -> TextView -> EditText
             if (className `is` EditText::class.java) return EditField
 
+            // TODO: consider checking node.isEditable
+
             // View -> TextView -> CheckedTextView
             if (className `is` CheckedTextView::class.java) return Checkable.TextView
 

diff --git a/app/src/main/java/com/neo/speaktouch/utils/NodeValidator.kt b/app/src/main/java/com/neo/speaktouch/utils/NodeValidator.kt
@@ -45,6 +45,7 @@ object NodeValidator {
      */
     private fun hasTextToRead(node: AccessibilityNodeInfoCompat): Boolean {
 
+        // TODO: Replace with node.getContent().isNotNullOrEmpty()
         return listOf(
             node.text,
             node.hintText?.takeIf { node.isEditable },
@@ -106,7 +107,8 @@ object NodeValidator {
 
         if (node.isCheckable) return true
 
-        if (node.isEditable) return true // TODO: Consider removing after issue #88
+        // TODO: Consider removing after issue #88
+        if (node.isEditable) return true
 
         return hasTextToRead(node)
     }

diff --git a/app/src/main/java/com/neo/speaktouch/utils/extension/AccessibilityNodeInfo.kt b/app/src/main/java/com/neo/speaktouch/utils/extension/AccessibilityNodeInfo.kt
@@ -289,5 +289,6 @@ fun AccessibilityNodeInfoCompat.getContent(
     if (text.isNotNullOrEmpty()) {
         return text
     }
+
     return null
 }
diff --git a/app/src/main/java/com/neo/speaktouch/utils/extension/CharSequence.kt b/app/src/main/java/com/neo/speaktouch/utils/extension/CharSequence.kt
@@ -30,9 +30,9 @@ inline fun <T : CharSequence> T?.ifEmptyOrNull(
     }
 }
 
-
-
+// TODO: Consider use a cache to avoid multiple calls to Class.forName
 infix fun CharSequence.`is`(childClass: Class<*>): Boolean {
+
     if (equals(childClass.name)) return true
     if (isEmpty()) return false