Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smiDE post #123

Open
wants to merge 13 commits into
base: Main
Choose a base branch
from
Open

smiDE post #123

wants to merge 13 commits into from

Conversation

dan11mcguire
Copy link
Collaborator

A very simple scratch space post with links to DE preprint + NanoStringBiostats/smiDE github repo (currently private).

Main vignette for the package in the README of github page.

@dan11mcguire dan11mcguire mentioned this pull request Nov 5, 2024
Copy link
Collaborator

@eveilyeverafter eveilyeverafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks okay as-is but it can be enhanced by:

  • adding a statement that the package vignette is there for further exploration.
  • It would be great if you could include a figure for the main blog page as well.

Right now the smiDE repo is not accessible so the links do not work. Having that repo be public is gating this post.

@dan11mcguire
Copy link
Collaborator Author

It looks okay as-is but it can be enhanced by:

* adding a statement that the package vignette is there for further exploration.

* It would be great if you could include a figure for the main blog page as well.

Right now the smiDE repo is not accessible so the links do not work. Having that repo be public is gating this post.

i will jazz it up

@dan11mcguire
Copy link
Collaborator Author

@eveilyeverafter , I've jazzed up the post with detailed walk through of main sections in the paper and added a bunch of figures.
Ready for your review again when you have time.

@patrickjdanaher
Copy link
Collaborator

Comments on the post itself:

  • Avoid words like "exciting", which lacks oomph.
  • 2nd figure, examples of DE questions: spell it out a little more in the bullet points, for example, "How does the expression of genes in T cells differ when located in stroma vs. tumor bed? (Left panel, blue vs. purple points.)
  • "tumor-native epithelial cells" - I'd just say "cancer cells"
  • "CD79A retains the significance in the SRE model" - delete "the"
  • intro paragraph: I'd emphasize the value proposition here: legacy approaches will very often lead you astray, and smiDE is a solution.

@patrickjdanaher
Copy link
Collaborator

REALLY nice package vignette. Only comment would be to provide a very visible commentary on runtime considerations and recommended models.

@dan11mcguire
Copy link
Collaborator Author

@patrickjdanaher thanks, I think I've addressed your comments above for the post.

Here is a new version for the intro paragraph, let me know any suggestions or edits

Differential Expression Analysis With Spatially Correlated Data

Led by the brilliant Ana Gabriela Vasconcelos, we’re excited to present a preprint “Differential Expression Analysis for Spatially Correlated Data” (Vasconcelos et al. 2024), discussing opportunities and unique challenges fundamental to differential expression (DE) analyses with spatial data.

We find that traditional DE methods applied to spatial data result in high rates of false discovery, and benchmark performance of different modeling strategies in terms of false discovery rates, power, effect size estimation, and computational complexity.

We provide general methodology recommendations for how a researcher should apply DE in their own study to avoid potential pitfalls that can damage the integrity of an analysis. Tools for methods discussed in the paper are implemented in the R package smiDE, with vignettes and examples on the package’s github page.

A brief summary of highlights and takeaways from the paper are described throughout the rest of this post.

@dan11mcguire
Copy link
Collaborator Author

@patrickjdanaher fyi: added commentary on runtime considerations and recommended models in the github README / vignette

@dan11mcguire
Copy link
Collaborator Author

@eveilyeverafter @patrickjdanaher

I've added smiDE package as a submodule in this PR branch.
I've made INLA package a suggestion, and package will prompt user to install INLA if that method is specified, but otherwise works for other methods.

"'GP_INLA' is specified but INLA package is not installed.  To run a spatial model using INLA 'GP_INLA', please install the INLA R package: https://www.r-inla.org/download-install"

I've also updated the language for all of the functions, per Prajan's requirement.
There are no mentions of "contamination". Instead we now have i.e., "overlap_cells_ratio_metric" instead of "contamination_ratio_metric".

Post and README are also updated now to reflect the new language.

@eveilyeverafter
Copy link
Collaborator

Is the plan now to have the smiDE package within this repo instead of having it be a standalone repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants