-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smiDE post #123
base: Main
Are you sure you want to change the base?
smiDE post #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks okay as-is but it can be enhanced by:
- adding a statement that the package vignette is there for further exploration.
- It would be great if you could include a figure for the main blog page as well.
Right now the smiDE repo is not accessible so the links do not work. Having that repo be public is gating this post.
i will jazz it up |
@eveilyeverafter , I've jazzed up the post with detailed walk through of main sections in the paper and added a bunch of figures. |
Comments on the post itself:
|
REALLY nice package vignette. Only comment would be to provide a very visible commentary on runtime considerations and recommended models. |
@patrickjdanaher thanks, I think I've addressed your comments above for the post. Here is a new version for the intro paragraph, let me know any suggestions or edits
|
@patrickjdanaher fyi: added commentary on runtime considerations and recommended models in the github README / vignette |
@eveilyeverafter @patrickjdanaher I've added
I've also updated the language for all of the functions, per Prajan's requirement. Post and README are also updated now to reflect the new language. |
Is the plan now to have the smiDE package within this repo instead of having it be a standalone repo? |
A very simple scratch space post with links to DE preprint + NanoStringBiostats/smiDE github repo (currently private).
Main vignette for the package in the README of github page.