Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements the possibility to run different resolutions for the marine analysis and background #3238

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Implements the possibility to run different resolutions for the marine analysis and background #3238

wants to merge 15 commits into from

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Jan 16, 2025 •
edited
Loading

Description

TODO: Write description.

Resolves #3230
Refs NOAA-EMC/GDASApp#1375

TODO: Add the dependencies

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Subset of the ci tests on hercules and hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@guillaumevernieres guillaumevernieres mentioned this pull request Jan 16, 2025
Draft
10 tasks
DavidNew-NOAA
DavidNew-NOAA requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@DavidNew-NOAA DavidNew-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one comment

sorc/link_workflow.sh
@@ -213,6 +213,10 @@ if [[ -d "${HOMEgfs}/sorc/gdas.cd" ]]; then
fix_ver="gdas_${gdas_sub}_ver"
${LINK_OR_COPY} "${FIX_DIR}/gdas/${gdas_sub}/${!fix_ver}" "${gdas_sub}"
done
# HACK, only for testing,don't merge.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidNew-NOAA DavidNew-NOAA DavidNew-NOAA requested changes

@shlyaeva shlyaeva Awaiting requested review from shlyaeva

@AndrewEichmann-NOAA AndrewEichmann-NOAA Awaiting requested review from AndrewEichmann-NOAA AndrewEichmann-NOAA will be requested when the pull request is marked ready for review AndrewEichmann-NOAA is a code owner

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA WalterKolczynski-NOAA will be requested when the pull request is marked ready for review WalterKolczynski-NOAA is a code owner

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA will be requested when the pull request is marked ready for review DavidHuber-NOAA is a code owner

@aerorahul aerorahul Awaiting requested review from aerorahul aerorahul will be requested when the pull request is marked ready for review aerorahul is a code owner

@KateFriedman-NOAA KateFriedman-NOAA Awaiting requested review from KateFriedman-NOAA KateFriedman-NOAA will be requested when the pull request is marked ready for review KateFriedman-NOAA is a code owner

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA Awaiting requested review from TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA will be requested when the pull request is marked ready for review TerrenceMcGuinness-NOAA is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the marine analysis at a resolution different from the deterministic
2 participants
@guillaumevernieres @DavidNew-NOAA