Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code changes for the implementation of the low-resolution B #1441

Draft
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

guillaumevernieres
Copy link
Contributor

@guillaumevernieres guillaumevernieres commented Jan 13, 2025

Still in draft mode

Dependencies

Work done in this PR

Interp to low-resolution:

  • variance partitioning
  • preparation of the perturbations for the envar
  • hybrid weights
  • ...

Testing

Visual check showing the variance explained by the steric height (30 members)
steic-explained-variance
left is native resolution, right is on the 1/2 deg grid.

"Science" note: The explained variance above is almost the opposite to what I would have expected, and what we saw in the previous offline ensemble, or even what we see in tendencies. Check if there's a bug in the explained variance calculation.

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmaerosnowDA
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_hybatmDA

@guillaumevernieres guillaumevernieres self-assigned this Jan 13, 2025
@guillaumevernieres guillaumevernieres added the hera-GW-RT Queue for automated testing with global-workflow on Hera label Jan 13, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 13, 2025
@emcbot
Copy link

emcbot commented Jan 13, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Mon Jan 13 21:38:37 UTC 2025 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Jan 13 22:32:01 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                 *SUCCESS*
Tests: Completed at Mon Jan 13 22:55:24 UTC 2025
Tests: 100% tests passed, 0 tests failed out of 53

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 13, 2025
shlyaeva
shlyaeva previously approved these changes Jan 14, 2025
Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, but I reviewed all the code changes, they look good to me.

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Jan 15, 2025
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Jan 15, 2025
@emcbot
Copy link

emcbot commented Jan 15, 2025

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Wed Jan 15 21:37:00 UTC 2025 on hfe09
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Jan 15 22:26:38 UTC 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                  *Failed*
Tests: Failed at Wed Jan 15 22:47:43 UTC 2025
Tests: 92% tests passed, 4 tests failed out of 53
	2042 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2043 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
	2054 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2055 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
Tests: see output at /scratch1/NCEPDEV/da/role.jedipara/CI/GDASApp/workflow/PR/1441/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 15, 2025
@guillaumevernieres guillaumevernieres added hercules-GW-RT Queue for automated testing with global-workflow on Hercules and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Jan 16, 2025
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Jan 16, 2025
@emcbot
Copy link

emcbot commented Jan 16, 2025

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Thu Jan 16 14:49:48 CST 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jan 16 15:26:46 CST 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                  *Failed*
Tests: Failed at Thu Jan 16 15:59:54 CST 2025
Tests: 81% tests passed, 10 tests failed out of 53
	2039 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marinebmat_202103250000 (Failed)
	2040 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlinit_202103250000 (Failed)
	2041 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlvar_202103250000 (Failed)
	2042 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2043 - test_gdasapp_C48mx500_3DVarAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
	2051 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marinebmat_202103250000 (Failed)
	2052 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlinit_202103250000 (Failed)
	2053 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlvar_202103250000 (Failed)
	2054 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2055 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
Tests: see output at /work2/noaa/da/role-da/CI/hercules/GDASApp/workflow/PR/1441/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hercules-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Jan 16, 2025
@guillaumevernieres guillaumevernieres added hercules-GW-RT Queue for automated testing with global-workflow on Hercules and removed hercules-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Jan 16, 2025
@emcbot emcbot added hercules-GW-RT-Running Automated testing with global-workflow running on Hercules and removed hercules-GW-RT Queue for automated testing with global-workflow on Hercules labels Jan 17, 2025
@emcbot
Copy link

emcbot commented Jan 17, 2025

Automated GW-GDASApp Testing Results:
Machine: hercules

Start: Thu Jan 16 18:07:19 CST 2025 on hercules-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Jan 16 18:43:06 CST 2025
---------------------------------------------------
Tests: ctest -j12 -R gdasapp -E atm_jjob|C96C48_ufs_hybatmDA|C96C48_hybatmaerosnowDA|C96C48_hybatmDA
Tests:                                  *Failed*
Tests: Failed at Thu Jan 16 19:14:24 CST 2025
Tests: 94% tests passed, 3 tests failed out of 53
	2053 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlvar_202103250000 (Failed)
	2054 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlchkpt_202103250000 (Failed)
	2055 - test_gdasapp_C48mx500_hybAOWCDA_gdas_marineanlfinal_202103250000 (Failed)
Tests: see output at /work2/noaa/da/role-da/CI/hercules/GDASApp/workflow/PR/1441/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hercules-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hercules-GW-RT-Running Automated testing with global-workflow running on Hercules labels Jan 17, 2025
@guillaumevernieres
Copy link
Contributor Author

Progress I guess. The hybrid failure is due to the saber "fix" that is not in develop yet @shlyaeva.

14: Not implemented: ctlVecSize not implemented yet for the block diffusion (/work2/noaa/da/role-da/CI/hercules/GDASApp/workflow/PR/1441/global-wor\
kflow/sorc/gdas.cd/bundle/saber/src/saber/../saber/blocks/SaberCentralBlockBase.h +104 ctlVecSize)

@shlyaeva
Copy link
Collaborator

@guillaumevernieres I'll try to expedite it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hercules-GW-RT-Failed Automated testing with global-workflow failed on Hera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants