Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editor contains previous comment when reloading page after successful comment to a proposal #875

Merged
merged 11 commits into from
Jul 17, 2024

Conversation

petersalomonsen
Copy link
Collaborator

@petersalomonsen petersalomonsen commented Jul 15, 2024

  • test for large proposal comment
  • test that the submitted transaction contains the pasted comment text
  • test that the comment appears in the log
  • test that the comment editor field is cleared after successful submission
  • test for reloading the page, check if the comment editor field is still empty ( which it is not )
  • fix implemented for devhub.near
  • fix implemented for events-committe.near by copying in the affected files as is, and running the proposal comment test suite in the workflow. Consider symlinking identical component files in the future
  • fix implemented for infrastructure-committee.near by applying the relevant changes into infrastructure component sources. The sources have diverged too much from devhub, so not possible to just use the devhub components as is. The same test suite for proposal comments are also applied to IC.
infrastructure-comment-draft.mp4
events-comment-draft.mp4
devhub-comment-draft.mp4

fixes #876

@petersalomonsen petersalomonsen changed the title test for large proposal comment, and test that the submitted transaction contains the pasted comment text large proposal comments should be cleared from draft Jul 15, 2024
@petersalomonsen petersalomonsen changed the title large proposal comments should be cleared from draft fix: large proposal comments should be cleared from draft Jul 15, 2024
@petersalomonsen petersalomonsen changed the title fix: large proposal comments should be cleared from draft fix: editor contains previous comment when reloading page after successful comment to a proposal Jul 15, 2024
@petersalomonsen
Copy link
Collaborator Author

@race-of-sloths please, include my PR in the Race

@race-of-sloths
Copy link

race-of-sloths commented Jul 15, 2024

@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@Tguntenaar 3

The average score is 3

@petersalomonsen check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@petersalomonsen petersalomonsen marked this pull request as ready for review July 17, 2024 09:45
@Tguntenaar
Copy link
Collaborator

@race-of-sloths score 3

@race-of-sloths
Copy link

🌟 Score recorded!

@Tguntenaar, thank you for scoring this pull request in the Race of Sloths!

Copy link
Collaborator

@Tguntenaar Tguntenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Megha-Dev-19 Megha-Dev-19 merged commit 33050e2 into main Jul 17, 2024
15 checks passed
@Megha-Dev-19 Megha-Dev-19 deleted the fix/large-proposal-comment branch July 17, 2024 15:50
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 3!
You have received 40 (30 base + 10 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @petersalomonsen! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

{
name: "events",
testMatch: /events\/.*.spec.js/, // (proposal|events)
testMatch: /(events|proposal)\/.*.spec.js/, // (proposal|events)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petersalomonsen this change is not in the CI only locally. These tests don't work for the events-commitee.near account, that is why I added events/proposals.spec.js.

Copy link
Collaborator Author

@petersalomonsen petersalomonsen Jul 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I did separate out the proposal comment test and added a workflow task for that as you can see here: https://github.com/NEAR-DevHub/neardevhub-bos/blob/main/.github/workflows/continuous-integration-workflow-events.yml#L22, but I forgot to set it for the whole proposal directory which I believe also will work. Will do so in the next PR ( #888 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment draft not cleared when reloading page after successful comment to a proposal
4 participants