-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: editor contains previous comment when reloading page after successful comment to a proposal #875
Conversation
…ion contains the pasted comment text
@race-of-sloths please, include my PR in the Race |
@petersalomonsen Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
The average score is 3 @petersalomonsen check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
…into fix/large-proposal-comment
event though the sources for IC have diverged from devhub, running the same test suite ensures that the comment draft clearing functionality pass the same test criterias
@race-of-sloths score 3 |
🌟 Score recorded!@Tguntenaar, thank you for scoring this pull request in the Race of Sloths! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ PR is finalized!Your contribution is much appreciated with a final score of 3! Another weekly streak completed, well done @petersalomonsen! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths |
{ | ||
name: "events", | ||
testMatch: /events\/.*.spec.js/, // (proposal|events) | ||
testMatch: /(events|proposal)\/.*.spec.js/, // (proposal|events) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petersalomonsen this change is not in the CI only locally. These tests don't work for the events-commitee.near
account, that is why I added events/proposals.spec.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I did separate out the proposal comment test and added a workflow task for that as you can see here: https://github.com/NEAR-DevHub/neardevhub-bos/blob/main/.github/workflows/continuous-integration-workflow-events.yml#L22, but I forgot to set it for the whole proposal directory which I believe also will work. Will do so in the next PR ( #888 ).
infrastructure-comment-draft.mp4
events-comment-draft.mp4
devhub-comment-draft.mp4
fixes #876