ct: add ::ContinualTask to various adapter enums
#29675
Conversation
danhhz
changed the title
::ContinualTask various adapter enums::ContinualTask to various adapter enums
danhhz
force-pushed
the
ct_todos_adapter
branch
from
c5daf0f to
1f83c28
Compare
| "max_continual_tasks", | ||
| value!(u32; 100), | ||
| "The maximum number of continual_tasks in the region, across all schemas (Materialize).", | ||
| true, |
There was a problem hiding this comment.
This makes the existence of CTs externally visible outside of mz_internal, but that seems better than me forgetting to flip it to public later 🤷 (Also, trying hard to not accumulate more TODO(ct)s, I have plenty)
There was a problem hiding this comment.
Nice!!
Not something you need to do in this PR, but to support comments on Continual Tasks we will need to add the new variant of CommentObjectType in planning.
| @@ -6750,6 +6774,31 @@ ORDER BY 1, 2"#, | |||
| access: vec![PUBLIC_SELECT], | |||
| }); | |||
|
|
|||
| pub static MZ_SHOW_CONTINUAL_TASKS: LazyLock<BuiltinView> = LazyLock::new(|| BuiltinView { | |||
There was a problem hiding this comment.
Not required in this PR but we generally index the SHOW X commands, example
|
Sounds good! Given the amount of time I have this week and how likely it is that this will rot, I might pick those two up as TODO(ct)s :). Will add those, rebase, get a nightlies in, and see if I can get this merged |
May as well rip off the band-aid and get it over with.
danhhz
force-pushed
the
ct_todos_adapter
branch
from
d13e8e2 to
2b2c6ba
Compare
|
TFTR! |
Followups from MaterializeInc#29675. Plus resolve a couple other small TODOs.
May as well rip off the band-aid and get it over with.
Touches MaterializeInc/database-issues#8427
Motivation
Tips for reviewer
This is the first time I've had to make a change to the catalog protos, and I think I missed some steps :)
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.