Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ct: get comments and SHOW working #29769

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

danhhz
Copy link
Contributor

@danhhz danhhz commented Sep 27, 2024

Followups from #29675.

Plus resolve a couple other small TODOs.

Touches database-issues#8427

Motivation

  • This PR adds a known-desirable feature.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Followups from MaterializeInc#29675.

Plus resolve a couple other small TODOs.
@danhhz danhhz requested a review from ParkMyCar September 27, 2024 21:02
@danhhz danhhz requested a review from a team as a code owner September 27, 2024 21:02
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danhhz
Copy link
Contributor Author

danhhz commented Sep 30, 2024

TFTR!

@danhhz danhhz merged commit f57c1f2 into MaterializeInc:main Sep 30, 2024
80 checks passed
@danhhz danhhz deleted the ct_comments_show branch September 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants