-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π©Ή (signer-eth) [NO-ISSUE]: Add review user interraction for sign typed obj #613
Merged
+19
β4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ
1 Skipped Deployment
|
aussedatlo
force-pushed
the
fix/no-issue-sign-typed-object-review
branch
from
January 15, 2025 16:34
0b45b3e
to
d20d8c8
Compare
paoun-ledger
approved these changes
Jan 15, 2025
aussedatlo
force-pushed
the
fix/no-issue-sign-typed-object-review
branch
from
January 16, 2025 10:23
d20d8c8
to
9c4dd5a
Compare
aussedatlo
changed the base branch from
feat/dsdk-639-nano-s-clear-signing
to
develop
January 16, 2025 10:28
jiyuzhuang
reviewed
Jan 16, 2025
.changeset/funny-rockets-glow.md
Outdated
"@ledgerhq/device-signer-kit-ethereum": patch | ||
--- | ||
|
||
Add user interraction for sign typed object device action that was removed before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: interaction
aussedatlo
force-pushed
the
fix/no-issue-sign-typed-object-review
branch
from
January 16, 2025 15:05
9c4dd5a
to
9a1b180
Compare
jiyuzhuang
approved these changes
Jan 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
Restore the user interaction during the provide
SignTypedObjectDA
that was removed.β Context
β Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
π§ Checklist for the PR Reviewers