Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 (signer-eth) [NO-ISSUE]: Add review user interraction for sign typed obj #613

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Jan 15, 2025

πŸ“ Description

Restore the user interaction during the provide SignTypedObjectDA that was removed.

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@aussedatlo aussedatlo requested a review from a team as a code owner January 15, 2025 15:44
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 16, 2025 3:06pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 16, 2025 3:06pm

Copy link
Contributor

github-actions bot commented Jan 15, 2025

Messages
βœ… Danger: All checks passed successfully! πŸŽ‰

Generated by 🚫 dangerJS against 9a1b180

@aussedatlo aussedatlo marked this pull request as draft January 15, 2025 16:25
@aussedatlo aussedatlo force-pushed the fix/no-issue-sign-typed-object-review branch from 0b45b3e to d20d8c8 Compare January 15, 2025 16:34
@aussedatlo aussedatlo marked this pull request as ready for review January 15, 2025 16:35
"@ledgerhq/device-signer-kit-ethereum": patch
---

Add user interraction for sign typed object device action that was removed before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: interaction

@aussedatlo aussedatlo force-pushed the fix/no-issue-sign-typed-object-review branch from 9c4dd5a to 9a1b180 Compare January 16, 2025 15:05
@aussedatlo aussedatlo enabled auto-merge January 16, 2025 15:09
@aussedatlo aussedatlo added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@aussedatlo aussedatlo added this pull request to the merge queue Jan 17, 2025
Merged via the queue into develop with commit 3f04fe1 Jan 17, 2025
10 checks passed
@aussedatlo aussedatlo deleted the fix/no-issue-sign-typed-object-review branch January 17, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants