🩹 (signer-eth) [NO-ISSUE]: Add review user interraction for sign type…

…d obj (#613)
LedgerHQ · Jan 17, 2025 · 3f04fe1 · 3f04fe1
2 parents e0e2be7 + 9a1b180
commit 3f04fe1
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/.changeset/funny-rockets-glow.md b/.changeset/funny-rockets-glow.md
@@ -0,0 +1,5 @@
+---
+"@ledgerhq/device-signer-kit-ethereum": patch
+---
+
+Add user interaction for sign typed object device action that was removed before
diff --git a/...eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.test.ts b/...eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.test.ts
@@ -167,7 +167,7 @@ describe("SignTypedDataDeviceAction", () => {
         },
         {
           intermediateValue: {
-            requiredUserInteraction: UserInteractionRequired.None,
+            requiredUserInteraction: UserInteractionRequired.SignTypedData,
           },
           status: DeviceActionStatus.Pending,
         },
@@ -277,7 +277,7 @@ describe("SignTypedDataDeviceAction", () => {
         },
         {
           intermediateValue: {
-            requiredUserInteraction: UserInteractionRequired.None,
+            requiredUserInteraction: UserInteractionRequired.SignTypedData,
           },
           status: DeviceActionStatus.Pending,
         },
@@ -437,7 +437,7 @@ describe("SignTypedDataDeviceAction", () => {
         },
         {
           intermediateValue: {
-            requiredUserInteraction: UserInteractionRequired.None,
+            requiredUserInteraction: UserInteractionRequired.SignTypedData,
           },
           status: DeviceActionStatus.Pending,
         },
@@ -504,7 +504,7 @@ describe("SignTypedDataDeviceAction", () => {
         },
         {
           intermediateValue: {
-            requiredUserInteraction: UserInteractionRequired.None,
+            requiredUserInteraction: UserInteractionRequired.SignTypedData,
           },
           status: DeviceActionStatus.Pending,
         },

diff --git a/...gner-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.ts b/...gner-eth/src/internal/app-binder/device-action/SignTypedData/SignTypedDataDeviceAction.ts
@@ -195,6 +195,16 @@ export class SignTypedDataDeviceAction extends XStateDeviceAction<
           },
         },
         ProvideContext: {
+          entry: assign({
+            intermediateValue: {
+              requiredUserInteraction: UserInteractionRequired.SignTypedData,
+            },
+          }),
+          exit: assign({
+            intermediateValue: {
+              requiredUserInteraction: UserInteractionRequired.None,
+            },
+          }),
           invoke: {
             id: "provideContext",
             src: "provideContext",