Issue #64: added n_init to kmeans #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
Sep 30, 2016
| @@ -43,18 +45,37 @@ function kmeans(X::Matrix, k::Int; | |||
| weights=nothing, | |||
| init=_kmeans_default_init, | |||
| maxiter::Integer=_kmeans_default_maxiter, | |||
| n_init::Integer=_kmeans_default_n_init, | |||
There was a problem hiding this comment.
Please use 4 space indents rather than tabs
ararslan
reviewed
Sep 30, 2016
|
|
||
| function kmeans!{T<:AbstractFloat}(X::Matrix{T}, centers::Matrix{T}; | ||
| weights=nothing, | ||
| maxiter::Integer=_kmeans_default_maxiter, | ||
| tol::Real=_kmeans_default_tol, | ||
| display::Symbol=_kmeans_default_display) | ||
|
|
There was a problem hiding this comment.
Unrelated (and unnecessary) change--best to keep PRs focused on the task at hand
ararslan
reviewed
Sep 30, 2016
| @@ -17,12 +17,14 @@ const _kmeans_default_init = :kmpp | |||
| const _kmeans_default_maxiter = 100 | |||
| const _kmeans_default_tol = 1.0e-6 | |||
| const _kmeans_default_display = :none | |||
| const _kmeans_default_n_init = 10 | |||
There was a problem hiding this comment.
Out of curiosity, what's the motivation for a default of 10?
There was a problem hiding this comment.
10 was chosen as this is the default for sklearn n_init param, and since we are duplicating this functionality, I just took this value.
ararslan
reviewed
Sep 30, 2016
| maxiter=maxiter, | ||
| tol=tol, | ||
| display=display) | ||
| n_init > 0 || error("n_init must be greater than 0") |
There was a problem hiding this comment.
Since n_init is a function argument, the error should be an ArgumentError. You can change this to
n_init > 0 || throw(ArgumentError("n_init must be greater than 0"))
lbollar
force-pushed
the
pull-request/775eefcd
branch
from
775eefc to
ea03689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing n_init feature from sklearn mentioned in Issue 64.
First ever Julia or package commit, please let me know errors or what needs to be cleaned up.