-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jedi container images. #1239
Conversation
@eap Note that we just bumped odc from 1.4.6 to 1.5.2 in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, PTAL. Also I'm re-running all tests.
Alright this is ready for another round of reviews, lets push to get this in even if it does have some warts because this has been churning on merge issues for the last week and I think at this point it'd be better to get in the current checkpoint than to continue to wait for it to be perfect. I am building all the containers right now on a ubuntu host and I won't submit if they don't build, but I also won't block on passing a build of jedi-bundle (which so far has been a game of whack-a-mole with new issues affecting the different environments reflective of the overall issues blocking the release) Note: I have manually merged the container changes from #1275. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience with this PR. I'll enable auto-merge and close #1275.
Edit. I won't enable auto-merge since you said you will submit after your local tests passed. |
I was able to successfully build all images and I also attempted configuration of the jedi-bundle. This container is still subject to issue #1269 (the FMS OpenMP::OpenMP_C linker issue), but otherwise is ready for submission. I think its reasonable to expect there may be further updates to the containers either prior to the release or after the release, as necessary to support CI, but for now this is causing too many merge conflicts so I'll get it submitted. |
This change updates our container images used for JEDI continuous testing and shared to make building JEDI easier for new users familiar with docker. The following changes have been added to this batch.
containers/specs/jedi-ci.yaml
to the latest versions used elsewhere in spack-stack.Testing
These images were all successfully built on an ubuntu host, then were used to build and test the jedi-bundle on an AWS host (as is required for JEDI CI).
Applications / Systems affected
JEDI CI
Issue(s) addressed
Fixes #1231
Fixes #1219
Fixes #1218
Checklist
Note: Multiple issues are addressed, but all affect the container configuration and are interdependent.