TTSD-5652 enforce minimum TLS version 1.2 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr3cj
requested review from
elementalvoid,
physik932,
Jdmorrisett,
Howl1935 and
mubarak-j
kr3cj
commented
Apr 22, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| ## Changelog | |||
|
|
|||
| ### `1.3.0` | |||
There was a problem hiding this comment.
I wasn't sure whether to make this a patch release or a minor release since previous attempts to enforce TLS 1.2 were already made. Open to suggestions.
kr3cj
commented
Apr 22, 2024
| acm_certificate_arn = aws_acm_certificate.cert.arn | ||
| ssl_support_method = "sni-only" | ||
| acm_certificate_arn = aws_acm_certificate.cert.arn | ||
| minimum_protocol_version = "TLSv1.2_2021" |
There was a problem hiding this comment.
|
New Issues
Fixed Issues
|
elementalvoid
approved these changes
Apr 22, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| ## Changelog | |||
|
|
|||
| ### `1.3.0` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket for more information.
Previous changes to enforce TLS version 1.2 only changed it for TLS to the origin, not to the client. This PR attempts to fix that.
PR for consuming it: https://github.com/Ibotta/ipn-portal-infrastructure/pull/136