Skip to content

Commit

Permalink
Merge pull request #9 from Ibotta/TTSD-5652
Browse files Browse the repository at this point in the history
TTSD-5652 enforce minimum TLS version 1.2
  • Loading branch information
kr3cj authored Apr 22, 2024
2 parents 6427f98 + dd10fe7 commit 3554980
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 13 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## Changelog

### `1.2.7`

- specify minimum SSL protocol as `TLSv1.2_2021`

### `1.2.6`

- ignore `web_acl_id` in Cloudfront
Expand All @@ -13,4 +17,4 @@

### `1.2.4`

- Add `aws_s3_bucket_versioning`, and tag s3 buckets per org guidelines.
- Add `aws_s3_bucket_versioning`, and tag s3 buckets per org guidelines.
11 changes: 1 addition & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,7 @@

This Terraform module works together with AWS Route53, S3, ACM and CloudFront to create permanent redirect of a domain to a target URL.

Both www and apex A records are created and pointed to a CloudFront distribution. The distribution accepts HTTP and HTTPS* connections (free autorenewing ACM certificate is used for HTTPS). The origin for CloudFront distribution is a S3 hosted website with redirect-all rule. This solution is cheap and maintenance free.

## Disclaimer

* = Please note that while the distribution accepts HTTPS connections, the "vanity" domain that it creates behind the scenes may accept insecure SSL protocols (e.g. TLS 1.0 and TLS 1.1). So if you are utilizing this module to create redirects on publicly accessible domains, they may trip the SecOps's teams security scans. However, since this module redirects traffic to non-vanity domains (which hopefully don't accept insecure TLS protocols), the risk should be low. If you [communicate this to the SecOps team](https://ibotta.atlassian.net/wiki/spaces/SEC/pages/2305269274/Communicating+With+The+SecOps+Team), they should be able to mark it as such.

References:
* https://ibotta.atlassian.net/browse/TTSD-5652
* https://www.reddit.com/r/aws/comments/156w1fh/disable_tls_v10_and_v11/
* https://www.reddit.com/r/aws/comments/don7nl/how_to_disable_cloudfront_tls_v10_without_a/
Both www and apex A records are created and pointed to a CloudFront distribution. The distribution accepts HTTP and HTTPS connections (free autorenewing ACM certificate is used for HTTPS). The origin for CloudFront distribution is a S3 hosted website with redirect-all rule. This solution is cheap and maintenance free.

**Requirements:** DNS Zone in Route53

Expand Down
5 changes: 3 additions & 2 deletions cloudfront.tf
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ resource "aws_cloudfront_distribution" "redirect" {
}

viewer_certificate {
acm_certificate_arn = aws_acm_certificate.cert.arn
ssl_support_method = "sni-only"
acm_certificate_arn = aws_acm_certificate.cert.arn
minimum_protocol_version = "TLSv1.2_2021"
ssl_support_method = "sni-only"
}

tags = var.tags
Expand Down

0 comments on commit 3554980

Please sign in to comment.