[74] Enter Evaluators A11y Fix #343
Conversation
app/views/evaluators/index.html.erb
Outdated
| <p>Create and manage a list of evaluators for the challenge.</p> | ||
| <h2 class="padding-top-3">Add Evaluators</h2> | ||
| <p>Evaluators will not be assigned to submissions until you assign in the submission detail view.</p> | ||
| <%= form_with(model: EvaluatorInvitation.new, url: phase_evaluators_path(@phase), method: :post, local: true) do |form| %> | ||
| <%= form_with(model: @evaluator_invitation || EvaluatorInvitation.new, url: phase_evaluators_path(@phase), method: :post, local: true, data: { controller: "evaluator-form modal" }, html: { novalidate: true }) do |form| %> |
There was a problem hiding this comment.
the evaluator-form stimulus controller doesn't exist, did you mean to use evaluation-form controller?
There was a problem hiding this comment.
since you're using the evaluation-form#validatePresence function here, I think it would be good to extract that functionality into a separate controller to be used in both places. the rest of the EvaluationFormController related to the EvaluationForm fields can stay there. that way we'll have a reusable form validation controller for other stimulus forms.
| end | ||
|
|
||
| handle_failed_invitation(result) |
There was a problem hiding this comment.
I'm seeing some inconsistency with the error message display depending on the path it takes. Can we try to ensure that if there are any validation issues with the name(s) missing, that the First & Last Name label is always highlighted in red (as it does for new users)?
existing user
new user
There was a problem hiding this comment.
The first screenshot is also missing the inline error text label describing the issue.
There was a problem hiding this comment.
There is also a case where only the first name is entered, First & Last Name label should be red:
| @@ -44,6 +45,24 @@ def resend_invitation(invitation) | |||
|
|
|||
| private | |||
|
|
|||
| def update_name_for_existing_user(user) | |||
| names = @invitation_params[:full_name].to_s.strip.split(/\s+/, 2) | |||
There was a problem hiding this comment.
I feel like it's potentially problematic to duplicate this field parsing logic with the EvaluatorInvitation model, in case things change in the future. Can you extract these into a single function? Something like User.split_full_name(full_name) => [first, last]
For the validation error message, you can just have a method that adds those errors directly to the model if first_name or last_name are blank. Actually it might be even easier to build a fake EvaluatorInvitation model first (without saving), check if it's valid, and if so then update the user. If it's invalid you can return the invalid Invitation with its errors. That way you're reusing the Invitation name splitting logic and you can get the invitation's first_name/last_name to update the User when the name is valid. WDYT?
Related ticket: #200 #74
Figma
Changes made in this PR:
when adding that user as an evaluator to a challenge phase,
then require and update the user with the provided first and last name.
Updated UI
Validation errors
Empty form
Only a first name
Missing last name
User with invalid role
Required first and last name for existing user
Existing user without first and last name updated with name entered
Mobile
WAVE