Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter Evaluators #74

Open
47 of 67 tasks
r-bartlett-gsa opened this issue Jul 31, 2024 · 3 comments · Fixed by #243 · May be fixed by #343
Open
47 of 67 tasks

Enter Evaluators #74

r-bartlett-gsa opened this issue Jul 31, 2024 · 3 comments · Fixed by #243 · May be fixed by #343

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Jul 31, 2024

User story

As a challenge manager, in order to have the submissions of my challenge reviewed and scored by evaluators, I would like evaluators to be available within the system for assignment to submissions.

Acceptance criteria:

  • Within the submission management section for each challenge, a challenge manager can enter as many evaluators as needed for their challenge:
    • An evaluator name (first and last name)
    • An evaluator email address
    • Once a new evaluator is added, they appear on the entered evaluator list
  • Entered evaluators list shows the following information:
    • First and last name
    • Email address
    • User role
      • Evaluator
      • Public Solver
      • Challenge manager
    • User status
      • Invite sent (new users who are not in challenge.gov system and must create a new account)
      • Available (an evaluator that is approved)
      • Awaiting Approval (new users who created an account an are waiting for the admin to approve the account)
      • Role Change Needed (public solver or challenge manager in challenge.gov system who require their role changed to an evaluator by an admin user) User Status in Evaluator List for Existing Users #287
    • Number of assigned submissions for that challenge
    • An option to delete an evaluator, Delete Evaluators #112
    • An option to view assigned submissions View Evaluator's Submissions #179
  • Entered users are sent an email notification/invite notifying them of being assigned to challenge as an evaluator Evaluation assignment notification #97
  • Evaluator role approval process is the same as challenge managers role approval process
  • Entered users who are new to challenge.gov system are saved with an evaluator role
    • When an entered evaluator creates login.gov account for challenge.gov, they are able to login as an evaluator (and have appropriate permissions to site functions)
    • If an entered evaluator already has an account with challenge.gov (challenge manager, public solver or admin roles), an appropriate role and status is displayed
      • Entered user's role must be manually changed by an admin user
    • Post-MVP: If an entered evaluator already has an account with challenge.gov, they are assigned a second role of an evaluator and the next time they login, they have permissions of an evaluator role, Allow for multiple user roles Challenge_gov#1361
  • Entered and approved evaluators are available for assignment to submissions, Assign Evaluators to a Submission - Manual #75

Dev tasks:

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
  • Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
  • Database changes have been peer reviewed for index changes and performance bottlenecks
  • PR that changes or adds UI
    • include a screenshot of the WAVE report for the altered pages
    • Confirm changes were validated for mobile responsiveness
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
  • Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Usability testing: mobile and desktop (Tracy or Marni)
  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Aug 8, 2024

Some button styles, colors and labels may have changed and screenshots below may reflect outdated styles. Please refer to Figma for latest designs.
Misalignment in styles, colors and labels should not affect the completion of development work. There will be additional user stories towards the end of this epic or MVP to bring uniformity to styles and colors.
If significant difference is noticed in features / functionality, please contact Renata.

Image

Image

Image

@r-bartlett-gsa
Copy link
Member Author

r-bartlett-gsa commented Nov 22, 2024

@stepchud

  1. When a user who's already in challenge.gov system is entered as an evaluator we should save their name even the current record of that user does not have the name. Given that entering evaluators requires the name, we should save it.
    image
  2. Form validation should show inline error messages
  3. Is there a character limit for page title? This does not display a full challenge title, it should say "Eval Challenge - Test - Phase 1"
    image
  4. For Add to Evaluator List button, make icon decorative alt=”” so screen reader doesn’t repeat “Add evaluator” twice.
    <img class="usa-icon--size-3 icon-white" alt="Add evaluator"
  5. Please check DoD list

@r-bartlett-gsa
Copy link
Member Author

Note: availability of evaluators for assignments will need to be tested at a later time once #75 is completed.

@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/31/24 milestone Dec 18, 2024
@emmabjj emmabjj linked a pull request Jan 3, 2025 that will close this issue
@r-bartlett-gsa r-bartlett-gsa linked a pull request Jan 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants