Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tj/fee contract improvements #1877

Closed
wants to merge 4 commits into from
Closed

Tj/fee contract improvements #1877

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
960bd34
remove used log event
0xkato Aug 19, 2024
606dd6b
hardcode variables to save gas
0xkato Aug 19, 2024
15f8063
clean up
0xkato Aug 19, 2024
23e36d4
error correction
0xkato Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions contracts/src/FeeContract.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,17 @@ contract FeeContract is Initializable, OwnableUpgradeable, UUPSUpgradeable {
//
/// @notice Notify a new deposit
event Deposit(address indexed user, uint256 amount);
event Log(string func, uint256 gas);

/// @notice upgrade event when the proxy updates the implementation it's pointing to
event Upgrade(address implementation);

// === Constants ===
//
/// @notice max amount allowed to be deposited to prevent fat finger errors
// @TODO confirm this amount with product
uint256 public maxDepositAmount = 1 ether;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it's an upgradable contract - we can't assign values to state variables on the implementation contract since we actually use the storage on the proxy contract. Only set these values in the initialize function


uint256 public maxDepositAmount;

uint256 public minDepositAmount;
uint256 public minDepositAmount = 0.001 ether;

// === Errors ===
//
Expand All @@ -49,8 +48,6 @@ contract FeeContract is Initializable, OwnableUpgradeable, UUPSUpgradeable {
function initialize(address multisig) public initializer {
__Ownable_init(multisig); //sets owner to msg.sender
__UUPSUpgradeable_init();
maxDepositAmount = 1 ether;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above but these values have to set here as opposed to assigning it upon declaration of the state variable.

minDepositAmount = 0.001 ether;
}

/// @notice Revert if a method name does not exist
Expand Down
Loading