Tj/fee contract improvements #1877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xkato
requested review from
nomaxg,
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
philippecamacho
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
LGTM but please check with @alysiahuggins regarding the upgradeability of the contract.
philippecamacho
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Some tests fail on my machine:
> just sol-test
[FAIL. Reason: DepositTooLarge()] test_depositForManyDifferentUsers() (gas: 44817)
[FAIL. Reason: DepositTooLarge()] test_depositManyTimesForTheSameUser() (gas: 40448)
[PASS] test_depositMaxAmount() (gas: 27816)
[FAIL. Reason: panic: arithmetic underflow or overflow (0x11)] test_depositMinAmount() (gas: 16785)
[FAIL. Reason: Error != expected error: 0xc56d46d3 != 0x702b3d90] test_invalidUserAddress() (gas: 24845)
| // === Constants === | ||
| // | ||
| /// @notice max amount allowed to be deposited to prevent fat finger errors | ||
| // @TODO confirm this amount with product | ||
| uint256 public maxDepositAmount = 1 ether; |
There was a problem hiding this comment.
as it's an upgradable contract - we can't assign values to state variables on the implementation contract since we actually use the storage on the proxy contract. Only set these values in the initialize function
| @@ -49,8 +48,6 @@ contract FeeContract is Initializable, OwnableUpgradeable, UUPSUpgradeable { | |||
| function initialize(address multisig) public initializer { | |||
| __Ownable_init(multisig); //sets owner to msg.sender | |||
| __UUPSUpgradeable_init(); | |||
| maxDepositAmount = 1 ether; | |||
There was a problem hiding this comment.
see comment above but these values have to set here as opposed to assigning it upon declaration of the state variable.
thanks for tagging me @philippecamacho , i left comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Minor gas optimizations
This PR does not:
Key places to review: