-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versioning #1637
versioning #1637
Conversation
This will make it easier to keep a somewhat consistent Rust API even as we add or change various fields in the underlying representation of the header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minus a few comments. I think @ggutoski should review types/src/v0/impls/block/
and types/src/v0/v0_1/block.rs
, mainly just to sign off on the organization of things; I don't think any logic has changed.
Also, I think we need something like reference_tests
and message_compat_tests
for the new versions, so that if we make any breaking changes to any existing supported version, a test will fail
Every field in every struct is now |
Can we not just duplicate the old directory structure under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮💨
This PR:
SeqTypes
to thetypes
crate.SeqTypes
things to review: