Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dgw): fix illegal invocation for send method on streaming player websocket proxy #1183

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix(dgw): fix illegal invocation for send method on streaming player websocket proxy #1183

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4f8ee3
fix(dgw): fix streaming player websocket proxy on illegal invocation for
irvingoujAtDevolution Jan 10, 2025
ac78f36
Update webapp/player-project/src/ws-proxy.ts
CBenoit Jan 10, 2025
01fe32c
Update webapp/player-project/src/ws-proxy.ts
CBenoit Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions webapp/player-project/src/ws-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,17 @@ const WebSocketProxy = new Proxy(window.WebSocket, {
}
return Reflect.set(target, prop, value);
},
get(target, prop, receiver) {
const value = Reflect.get(target, prop, receiver);
// Because these methods are part of the native WebSocket prototype,
// they must be called with the original WebSocket as `this`.
// If they're called with the Proxy as `this`, it results in an "illegal invocation".
// Binding them to the underlying `target` (the real WebSocket) avoids this issue.
CBenoit marked this conversation as resolved.
Show resolved Hide resolved
if (typeof value === 'function') {
return value.bind(target);
}
return value;
},
});
},
});
Expand Down
Loading