Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dgw): fix illegal invocation for send method on streaming player websocket proxy #1183

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Jan 10, 2025

Fix the problem when Websocket send is called, we have an illegal invocation exception. The Websocket send method needs to be tied to the Websocket instance instead of the proxy, that is, the this keywords need to be bind to the correct object. This problem was introduced in the previous effort to intercept the close method for Websocket

Changelog: ignore

Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@CBenoit CBenoit changed the title fix(dgw): fix streaming player websocket proxy on illegal invocation for send method fix(dgw): fix illegal invocation for send method on streaming player websocket proxy Jan 10, 2025
@CBenoit
Copy link
Member

CBenoit commented Jan 10, 2025

@irvingoujAtDevolution Add Changelog: ignore at the bottom of your PR description if this fix is for something we didn’t release yet, and merge. Thank you!

@irvingoujAtDevolution irvingoujAtDevolution enabled auto-merge (squash) January 10, 2025 17:18
@irvingoujAtDevolution irvingoujAtDevolution merged commit f891342 into master Jan 10, 2025
36 checks passed
@irvingoujAtDevolution irvingoujAtDevolution deleted the fix-ws-proxy branch January 10, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants