Fix #181:Introduce pretty print and pager output for challenges #197
+40
−10
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,21 @@ | ||
| beautifulsoup4==4.7.1 | ||
| beautifultable==0.7.0 | ||
| boto==2.49.0 | ||
| boto3==1.9.88 | ||
| botocore==1.12.116 | ||
| click==6.7 | ||
| coverage==4.5.1 | ||
| coveralls==1.3.0 | ||
| docker==3.6.0 | ||
| flake8==3.0.4 | ||
|
|
||
| pre-commit==1.14.4 | ||
| pytest==3.5.1 | ||
| pytest-cov==2.5.1 | ||
| python-dateutil==2.7.3 | ||
| requests==2.20.0 | ||
| requests-toolbelt==0.8.0 | ||
| responses==0.9.0 | ||
| validators==0.12.2 | ||
| termcolor==1.1.0 | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RohanSreelesh Why is lxml removed as a dependency in this commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My build wasnt installing , then @yashdusing on gitter suggested removing this from requirements and setup.py after which I was able to install it successfully
The error can be found here https://imgur.com/g4wefJP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some development libraries are missing in the python package related to lxml, thus the package was not installing. You can find more details here.
We cannot remove it from the requirements as it would break some other parts of the code(for example, the build fails as the lmxl based tests are not passing).
The issue exists on windows due to the version of lxml (please refer to the second answer on the link about. maybe you could update the version of lxml in requirements.txt and try reinstalling on windows to resolve the issue.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand , I had done the solutions given in the link including the second answer but the build still didnt work for me unfortunately. I'll add it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added lxml back into requirements and setup.py but the build is still failing @pushkalkatara
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build is failing due to some more issues. You can get all the details here.